Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Auth MVP #8

Closed
5 tasks done
AdamYLiang opened this issue Dec 13, 2019 · 6 comments
Closed
5 tasks done

User Auth MVP #8

AdamYLiang opened this issue Dec 13, 2019 · 6 comments

Comments

@AdamYLiang
Copy link
Collaborator

AdamYLiang commented Dec 13, 2019

Looks good! Here are some changes:

Functionality

  • Nav bar should not appear during Signup/Login forms. Perhaps make those separate routes on the top level App. So you would have Login, Signup, and MainApp.

CSS

  • Larger styling on splash page and login forms. Use the inspector to see how big elements should be. Specifically buttons such as Log in and Try it FREE.
  • Remove How it works, Before & after, etc. in the nav bar since we will not have those links.
  • Style DemoUser like how the Google auth button looks like on original app
  • Session Form should be further down on the page and logo should be at the top. Buttons/input should be slightly larger.

I'd recommend putting your app and the original app side by side and seeing what looks off! Let me know if you have any questions about these changes.

@edherm
Copy link
Owner

edherm commented Dec 16, 2019

I have removed the extraneous nav bar links, increased the login and try it free buttons, increased the font-size of the splash page header, shifted the session form down the page, and added the logo to that.

I am still working on:

  • my Auth/Protected Routes
  • onFocus/Blur to change the class of my input labels so that they shrink and stay shrunk.

I'll update you again when I've finished these and have pushed them to Heroku.

@edherm
Copy link
Owner

edherm commented Dec 17, 2019

Hello, Adam!

Fixed:

  • auth/protected routes are working
  • I completely redid the CSS for:
    • login
    • signup
    • splash
    • main navbar

Some of the css that I started with was way too vague and I was having to fight it later in my styling.

Still needs work:

  • onFocus/Blur for the session form only works in one direction (shrinking the label when i select an input) and it doesn't work with my demo user button
  • my log in button on the session form is resisting my attempts to set it's size...
  • my signup yellow button is also resisting the urge to increase in size...
  • the main navbar should be sticky
  • the main navbar home button in the center

I am pushing these changes to heroku and will continue to work on the second bullet-list in the morning.

@edherm
Copy link
Owner

edherm commented Dec 17, 2019

I also noticed the text color remains the same on the navbar after logging in... I'll fix that in the AM as well.

@edherm
Copy link
Owner

edherm commented Dec 17, 2019

Hello Adam,

I have pushed my updates to heroku!

Immediately upon doing that, I noticed that I need to change my splash page text's line-spacing.

I also still need to make the nav bar sticky.

-Ed

@edherm
Copy link
Owner

edherm commented Dec 17, 2019

Adam!

I have pushed my updates to heroku, again!

This time I have made the nav bar sticky and fixed my splash page's line-height.

My auth inputs are not done. I am stuck on the floating labels...

PS This play by play is brought to you by all of the free coffee.

@AdamYLiang
Copy link
Collaborator Author

Gotcha, I'm taking a looking at the auth inputs right now and it seems a bit hard to click on the input fields. I assume thats due to the transition animation? I think what we have right now looks pretty solid though. If you want to move on from the floating labels/animations then you can! Even without the placeholders floating, the session form looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants