Fix potential buffer overflow in ec_glob #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skeeto
added a commit
to skeeto/editorconfig-core-c
that referenced
this pull request
Feb 17, 2024
Several overflows may occur in switch case '[' when the input pattern contains many escaped characters. The added backslashes leave too little space in the output pattern when processing nested brackets such that the remaining input length exceeds the output capacity. Therefore all these concatenations must also be checked. The ADD_CHAR was missed in 41281ea (editorconfig#87). The switch can exit exactly at capacity, leaving no room for the finishing '$', causing an overflow. These overflows were discovered through fuzz testing with afl.
skeeto
added a commit
to skeeto/editorconfig-core-c
that referenced
this pull request
Feb 18, 2024
Several overflows may occur in switch case '[' when the input pattern contains many escaped characters. The added backslashes leave too little space in the output pattern when processing nested brackets such that the remaining input length exceeds the output capacity. Therefore all these concatenations must also be checked. The ADD_CHAR was missed in 41281ea (editorconfig#87). The switch can exit exactly at capacity, leaving no room for the finishing '$', causing an overflow. These overflows were discovered through fuzz testing with afl.
xuhdev
pushed a commit
that referenced
this pull request
Feb 19, 2024
Several overflows may occur in switch case '[' when the input pattern contains many escaped characters. The added backslashes leave too little space in the output pattern when processing nested brackets such that the remaining input length exceeds the output capacity. Therefore all these concatenations must also be checked. The ADD_CHAR was missed in 41281ea (#87). The switch can exit exactly at capacity, leaving no room for the finishing '$', causing an overflow. These overflows were discovered through fuzz testing with afl.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CVE-2023-0341