Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #12 Add a test for "unset" value #16

Merged
merged 2 commits into from
Nov 17, 2017
Merged

Fix #12 Add a test for "unset" value #16

merged 2 commits into from
Nov 17, 2017

Conversation

ppalaga
Copy link
Contributor

@ppalaga ppalaga commented Nov 13, 2017

No description provided.

@ppalaga ppalaga mentioned this pull request Nov 13, 2017
Closed
@ppalaga
Copy link
Contributor Author

ppalaga commented Nov 13, 2017

@xuhdev could you please review? I checked that the new tests pass with both current core-c and current core-py.

@ppalaga
Copy link
Contributor Author

ppalaga commented Nov 16, 2017

@xuhdev as I said in #12 , this just codifies the current behavior of editorconfig-core-py and editorconfig-core-c. It would be nice to have it in the suite so that other implementations can makes sure that they comply too.

@ppalaga ppalaga mentioned this pull request Nov 16, 2017
Closed
xuhdev
xuhdev requested changes Nov 17, 2017
View reviewed changes
Copy link
Member

@xuhdev xuhdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good!

.gitignore
@@ -8,3 +8,6 @@ install_manifest.txt
# Generated by CTest
/Testing
CTestTestfile.cmake

# Eclipse
.project
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep the new line char.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 9b6999c

filetree/CMakeLists.txt Outdated
@@ -1,16 +1,16 @@
#
# Copyright (c) 2011-2012 EditorConfig Team
# All rights reserved.
#
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make these trailing whitespace removal into a separate commit.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I just noticed you have an .editorconfig file saying trim_trailing_whitespace = false. Hence I added that whitespace back in 861284f

@ppalaga
Copy link
Contributor Author

ppalaga commented Nov 17, 2017

@xuhdev thanks for the review, all your requests should be fixed in
9b6999c and 861284f .

@xuhdev xuhdev merged commit 0001aa2 into editorconfig:master Nov 17, 2017
@xuhdev
Copy link
Member

xuhdev commented Nov 17, 2017

Thanks!

@ppalaga
Copy link
Contributor Author

ppalaga commented Nov 18, 2017

Thanks for merging @xuhdev!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xuhdev xuhdev xuhdev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ppalaga @xuhdev