Fix tests. #106
Fix tests. #106
Conversation
package.json
Outdated
| "compile": "tsc", | ||
| "lint": "tslint --project tsconfig.json", | ||
| "postinstall": "node ./node_modules/vscode/bin/install", | ||
| "compile": "tsc -p ./", |
There was a problem hiding this comment.
-p ./ is implied when there is a tsconfig.json at project root, so why are you doing this?
There was a problem hiding this comment.
To be more obvious but I can drop it.
package.json
Outdated
| "lint": "tslint --project tsconfig.json", | ||
| "postinstall": "node ./node_modules/vscode/bin/install", | ||
| "compile": "tsc -p ./", | ||
| "lint": "tslint 'src/**/*.ts' 'test/**/*.ts'", |
There was a problem hiding this comment.
What was wrong with --project tsconfig.json? The way I had it, you don't have to duplicate the include paths.
There was a problem hiding this comment.
Haven't seen this be used in any other project, I can revert it.
package.json
Outdated
| "precompile": "node ./node_modules/vscode/bin/install", | ||
| "compile": "tsc", | ||
| "lint": "tslint --project tsconfig.json", | ||
| "postinstall": "node ./node_modules/vscode/bin/install", |
There was a problem hiding this comment.
I had issues w/ other projects if they were a dependency of another project, this would fail upon install, but considering this is an extension and shouldn't be a dependency of another project, I'll accept this.
There was a problem hiding this comment.
Come to think of it the only time vscode-test needs to be redownloaded is when there is a new version of vscode released. Considering though that vscode-test is needed only when on local or CI testing, I think it's safe.
(CI will always download a fresh copy as it executes npm install every time).
| 'applies edit' | ||
| ); | ||
| return await new Promise(resolve => { | ||
| return await new Promise<string>(async (resolve) => { |
There was a problem hiding this comment.
Where is resolve being called? I'm not seeing it.
|
Thanks a ton! These tests have been a bit of a PITA. |
Additionally, I made the following changes:
package.json.vscodefor testing doesn't need to be downloaded every time a compilation is triggered.testmessages as a test message is displays when test fails.os.EOLso tests can be run correctly also onWindows.