Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hasAddressLineN properties #237

Closed
VladimirAlexiev opened this issue Oct 24, 2016 · 8 comments
Closed

hasAddressLineN properties #237

VladimirAlexiev opened this issue Oct 24, 2016 · 8 comments

Comments

@VladimirAlexiev
Copy link

VladimirAlexiev commented Oct 24, 2016

fibo-fbc-fct-breg: has properties hasAddressLine1..4 and cites definitionOrigin http://www.leiroc.org/publications/gls/lou_20140620.pdf.

But do we need this seemingly random restriction to 4 address lines? We can have newlines in RDF literals, and thus accommodate any number of lines required.

Eg Dun & Bradstreet data has StreetAddressLine1..4 in one case, but MailingLabelLine1..8 in another case. how do you squeeze 8 DnB lines into 4 LEI/FIBO lines?

@VladimirAlexiev VladimirAlexiev changed the title hasAddressLineN propertis hasAddressLineN properties Oct 24, 2016
@trypuz
Copy link
Contributor

trypuz commented Oct 26, 2016

I could add that data properties like: hasAddressLine1, hasAddressLine2, etc. do not convey any interesting meaning. Instead, for addresses, I would suggest to use some more meaningful data properties like e.g. „hasStreetAddress”, "hasPostalCode", etc. and/or possibly some object properties connected to location (region, city, country).

@VladimirAlexiev
Copy link
Author

It has hasPostalCode, hasCity...
I am arguing that breaking up the address into an arbitrary number of lines is not useful.
And I agree with you that renaming hasAddressLine to hasStreetAddress is better, since it shows explicitly that's only street address (so hasCity and hasPostalCode should also be printed on a mailing label)

@ElisaKendall
Copy link
Contributor

There is an open issue in FND to refactor addresses. If you can do everything with hasAddressLine1, then there is no need to use the others in your application. Some business registries, including EDGAR filings with the SEC, require these fields, however, which is why they were introduced in FBC.

@VladimirAlexiev
Copy link
Author

@ElisaKendall Using just hasAddressLine1 would work, but it's better called hasStreetAddress. Since it's easy to split on newline and concat, I think FIBO shouldn't have an arbitrary number of fields, even if EDGAR and GLEI have such (is it 4 fields in both?)

@dallemang
Copy link
Contributor

This is an issue for FND, as Elisa pointed out, which already has an issue. This work continues there.

@VladimirAlexiev
Copy link
Author

@dallemang can you post the link to the FND issue (guess it's in the closed jira)

@rivettp
Copy link
Contributor

rivettp commented Jan 8, 2020

FWIW FIBO and the GLEIF ontology do have distinct properties for city, country, postalcode, region. The addressLines are used for the remainder, which could be street address, building, floor, apartment, PO Box, "c/o person ", suite etc. Which is broader than "street address" and can be very country-dependent.

@VladimirAlexiev
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants