Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust the ga.spec for gfortran 10 with -fallow-argument-mismatch workaround #4

Closed
marcindulak opened this issue Feb 1, 2020 · 8 comments

Comments

@marcindulak
Copy link
Contributor

Will you have time to look at GlobalArrays/ga#157?

Should I build ga-5.7 on all fedora/epel targets already after the workaround?

@marcindulak
Copy link
Contributor Author

I see I should wait for ga 5.7.1 #3 (comment)

@edoapra
Copy link
Owner

edoapra commented Feb 3, 2020

@marcindulak I have been using -std=legacy gfortran option when comping Global Arrays in NWChem
nwchemgit/nwchem@cfb5a82
Do you have any idea of the pros and cons of the two options

@marcindulak
Copy link
Contributor Author

https://gcc.gnu.org/onlinedocs/gfortran/Fortran-Dialect-Options.html

It looks like -fallow-argument-mismatch is more specific compared to -std=legacy

"Using this option is strongly discouraged. It is possible to provide standard-conforming code which allows different types of arguments by using an explicit interface and TYPE(*)."

vs

"The ‘legacy’ value is equivalent but without the warnings for obsolete extensions, and may be useful for old non-standard programs"

old non-standard programs does not sound good :), I think we want to advance the code, but changes to the code (if any are needed with just -fallow-argument-mismatch ) may introduce problems for other compilers.

@edoapra
Copy link
Owner

edoapra commented Feb 3, 2020

@marcindulak I have committed the needed change to hotfix/5.7.1
edoapra/ga@d8a4544

@marcindulak
Copy link
Contributor Author

I've added the gfortran 10 workaround directly to the ga.spec until 5.7.1 is released.

https://src.fedoraproject.org/rpms/ga/c/cd092566c780ceeb7c096fa996d07fa5df80c1f9?branch=master

@edoapra
Copy link
Owner

edoapra commented Feb 15, 2020

We might have 5.7.1 out soon.
https://github.com/GlobalArrays/ga/tree/hotfix/5.7.1

@edoapra
Copy link
Owner

edoapra commented Feb 29, 2020

@marcindulak
Copy link
Contributor Author

RPMS of 5.7.2 have been built.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants