Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dnsrepo.noc.org as subdomain source #110

Closed
Tracked by #51
edoardottt opened this issue Oct 12, 2023 · 4 comments · Fixed by #120
Closed
Tracked by #51

Add dnsrepo.noc.org as subdomain source #110

edoardottt opened this issue Oct 12, 2023 · 4 comments · Fixed by #120
Assignees
Labels
enhancement New feature or request go good first issue Good for newcomers GopherZone hacktoberfest help wanted Extra attention is needed

Comments

@edoardottt
Copy link
Owner

edoardottt commented Oct 12, 2023

#51 (comment)

@edoardottt edoardottt added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers hacktoberfest GopherZone go labels Oct 12, 2023
@iamshreeram
Copy link
Contributor

iamshreeram commented Oct 20, 2023

@edoardottt ,

Summary of the existing code -

  1. If the client key is provided in context, URL is built and the response is a json which is parsed
  2. If the auth key is nil, app calls the scrape function that extracts the data from webpage (table).

Quick question - Do we have to impl. the scrape function to get the data from the table? (Should be straightforward) or Should we implement the code to take up the client key?

@edoardottt
Copy link
Owner Author

It's up to you...
If you want you can implement both (if auth is present use 1 otherwise 2)
But just the scrape function is okay.

In the first case see how the virustotal auth is already implemented

@iamshreeram
Copy link
Contributor

@edoardottt , I can pick this up. I'm using goquery to scrape the table data from html page

@edoardottt
Copy link
Owner Author

Completed, thanks @iamshreeram !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request go good first issue Good for newcomers GopherZone hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants