Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use readonly macaroon by default #32

Merged
merged 1 commit into from
Sep 2, 2021

Conversation

mmilata
Copy link
Contributor

@mmilata mmilata commented Jul 30, 2021

Read-only privileges seems to be sufficient and it's always better to use the least powerful credentials. Been running lntop with the readonly macaroon for a while and didn't notice any problem. Did not test the docker image though.

@edouardparis
Copy link
Owner

This a good idea, but it may introduce compatibility issue for old version of lnd when the readonly macaroon was not always created.
I will certainly merge this for v0.2 version.
Thank you

@edouardparis
Copy link
Owner

edouardparis commented Aug 24, 2021

I tested with docker.
https://github.com/edouardparis/lntop/blob/master/docker/lntop/home/initial-config-template.toml#L10
s/admin/readonly
and we are good to go :)

@mmilata
Copy link
Contributor Author

mmilata commented Sep 2, 2021

Updated, looking forward to 0.2 release, let me know if there's anything I can do to help make it happen!

@edouardparis
Copy link
Owner

edouardparis commented Sep 2, 2021

We have enough change for a release, I will do it now.
Thank you ! Send me an invoice or link for tip !

@edouardparis edouardparis merged commit ea2b2ad into edouardparis:master Sep 2, 2021
@mmilata mmilata deleted the readonly-macaroon branch September 2, 2021 21:58
@mmilata
Copy link
Contributor Author

mmilata commented Sep 2, 2021

Great! I still haven't figured out how to receive payments without linking my node id and github id, feel free to tip here though: https://nixbitcoin.org/btcpayserver/apps/4D1Dxb5cGnXHRgNRBpoaraZKTX3i/pos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants