Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Font chooser / selector: ReadiumCSS built-in (inc. Dyslexic), and system #86

Closed
danielweck opened this issue Mar 5, 2018 · 4 comments
Closed

Font chooser / selector: ReadiumCSS built-in (inc. Dyslexic), and system #86

danielweck opened this issue Mar 5, 2018 · 4 comments
Labels
accessibility feature

Comments

@danielweck
Copy link
Member

UI suggestion: https://github.com/reactjs/react-autocomplete
@danielweck danielweck added this to the Second public release milestone Mar 5, 2018
@danielweck
Copy link
Member Author

danielweck commented Apr 9, 2018 •
edited
Loading

import SystemFonts = require("system-font-families");

https://www.npmjs.com/package/system-font-families

https://github.com/edrlab/r2-testapp-js/blob/15ad9100d8e22cf35886e5fed78c453aad887ee6/src/electron/renderer/index.ts#L693-L726

@danielweck
Copy link
Member Author

danielweck commented Apr 9, 2018 •
edited
Loading

For ReadiumCSS fonts:

https://github.com/edrlab/r2-testapp-js/blob/15ad9100d8e22cf35886e5fed78c453aad887ee6/src/electron/renderer/index.ts#L614-L647

and:

https://github.com/edrlab/r2-navigator-js/blob/21b96dc6d14f3e528554b3a89c92419488ec51a7/src/electron/renderer/webview/readium-css.ts#L435-L453

@danielweck
Copy link
Member Author

danielweck commented Apr 9, 2018 •
edited
Loading

The built-in ReadiumCSS fonts r2-navigator-js understands are the following string enumeration, or any other valid CSS font-family name:

DUO, DYS, OLD, MODERN, SANS, HUMAN, MONO

Use "DEFAULT" to use authored font styles.

Scarsniik added a commit to Scarsniik/readium-desktop that referenced this issue Apr 10, 2018
@Scarsniik
Add font selector on reader settings
66b4f81 
Fixes edrlab#86
@JayPanoz
Copy link

For reference, the original feature request for system fonts in the Readium CSS issue tracker: readium/readium-css#22

@JayPanoz JayPanoz mentioned this issue Apr 25, 2018
Closed
@llemeurfr llemeurfr removed this from the Second public release milestone May 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accessibility feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@danielweck @JayPanoz @llemeurfr @Scarsniik