Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT]: Always heating mode after sterilization #108

Closed
omenukas opened this issue May 8, 2023 · 26 comments
Closed

[ENHANCEMENT]: Always heating mode after sterilization #108

omenukas opened this issue May 8, 2023 · 26 comments
Assignees
Labels
enhancement New feature or request

Comments

@omenukas
Copy link

omenukas commented May 8, 2023

The water sterilization time is set in the pump itself. I noticed that after sterilization, the pump always switches to heating mode, regardless of the mode it was in before sterilization.
Is it possible to solve this problem so that after water sterilization the pump returns to the mode it was in before sterilization? After all, there is no need to turn on the heating in the summer.
Are some changes needed in the NR dashboard or is this a bug?

@omenukas omenukas added the enhancement New feature or request label May 8, 2023
@edterbak
Copy link
Owner

edterbak commented May 8, 2023

I think it is a bug.
It might be fixed in current version (JUST pushed out) beta v22.27

https://github.com/edterbak/NodeRed_Heishamon_control/tree/beta-1

If you can check this version and pay special attention to this, that would be awesome :)

THanks for the reporting !!

@edterbak edterbak self-assigned this May 8, 2023
@omenukas
Copy link
Author

omenukas commented May 9, 2023

I think it is a bug. It might be fixed in current version (JUST pushed out) beta v22.27

https://github.com/edterbak/NodeRed_Heishamon_control/tree/beta-1

If you can check this version and pay special attention to this, that would be awesome :)

THanks for the reporting !!

I did the flows update as described in the instructions and set test sterilization on the pump. However, after sterilization, the pump still switched to heating mode.
Is it possible that I have incorrectly added the room temperature sensor and it is affecting the incorrect operation of the pump after sterilization?
I didn't make any more changes.
Screenshot_20230509_152158_Home Assistant

@edterbak
Copy link
Owner

edterbak commented May 9, 2023

Ah, Im looking now at the code.
it is not a bug.
It is just not programmed as you and I thought it was.
I will have a look if it is doable to change. (it is complex in interaction with other functions... need to see...)

@edterbak
Copy link
Owner

I think I fixed it on my end. Did a testrun, and it worked. ofcourse the proof is in the pudding, so after upload/release the bughunting can start.

@edterbak edterbak added this to the Stable Release (v23.00) milestone May 10, 2023
edterbak added a commit that referenced this issue May 10, 2023
[2023-05-10] v22.28 beta (experimental). Changes:
- [Fix] - RTC function, the automation for OperatingMode had a hard time staying active... fixed it.
- [Enhancement] - Start DHW-run below XX C (SETTINGS tab). This triggers Forcefull DHW run (by scheduler)
- [Fix] - Solar function did not revert operating mode/SP in some scenarios.  #110
- [Fix] - Sterilization routine always reverts back to Operating Mode heat only. Now it is reverting the original OM befor the run. #108
@omenukas
Copy link
Author

Can I try it or do I have to wait for a new release?

@edterbak
Copy link
Owner

edterbak commented May 10, 2023

It is in current upload, v22.28

https://github.com/edterbak/NodeRed_Heishamon_control/tree/beta-1

@omenukas
Copy link
Author

I tried force sterilization. The problem remained the same - after sterilization, the pump switched to heating mode.
Before sterilization, "only DHW" mode was activated.

@edterbak
Copy link
Owner

Maybe we are talking about two different things.
How do you enabling the sterilisation ?
Through the scheduler or home dashboard?

@omenukas
Copy link
Author

Sterilisation is normally set on the heat pump's dashboard. This time I enabled the "force sterilisation" function in the app for testing.
Screenshot_20230510_203144_Home Assistant

@edterbak
Copy link
Owner

Ghehehe... Yes.
In node red dashboard, you also have a scheduler. In here, you can set a time and an action.
I have been fixing this. Hahaha... Miscommunication.

I will look at that toggle on the home screen.

You could try the NR scheduler as a replacement for the wallmounted unit scheduler. It is bigger and more flexible

@omenukas
Copy link
Author

Yesterday I set up the "scheduler" function in the app:

Screenshot_20230511_063437_Home Assistant

This is what I found this morning:

Screenshot_20230511_063233_Photos

@edterbak
Copy link
Owner

Are there schedules in the controler still active with heat only?
Can you post a screenshot of the RTC page?
Are you sure the operating mode was different befor the schedule?

@edterbak
Copy link
Owner

edterbak commented May 11, 2023

Did i correctly see you use not direct mode but compensation curve? (Should not be a problem, but nice to see) i have not used that myself. Only quick testing. On the Dutch forum nobody uses it too. I have had very little feedback on this part. Good to see it being used

@omenukas
Copy link
Author

It's been a few weeks since I've had the heating off and only the water heating on. That's why I raised this issue only now. In winter, when both heating and water preparation were turned on, switching to "only heating" after sterilisation did not cause any problems, but now the situation is not very good.
Yes, the pump is set to work according to the compensation curve.
I don't put any shedule settings in the pump or the app. Yesterday, just for testing, I set the sterilisation schedule in the app.
image
image

@edterbak
Copy link
Owner

Could you check if you have a value here:
image

and a little further down you could see "F_stored_next_operating_mode"
image

Normally, this variable should not be found.
Only during sterilization run, I expect this variable to contain the operating mode that was active befor the sterilization.

So if you cnt find it, it is good. (when not in a sterilization run)

@edterbak
Copy link
Owner

edterbak commented May 11, 2023

Found it.
The root cause is that variable "TOP4_Operating_Mode_State" is empty when the sterilization run is started.

The current value of TOP4_Operating_Mode_State should then be stored in "F_stored_next_operating_mode".
Now, F_stored_next_operating_mode is empty.

When the sterelization run ends, I send out the task to the broker to change the operating mode to the value of F_stored_next_operating_mode. But because this is empty, it sends out the value 0 (zero) which is Heat Only.

To solve this.
Can you post a screenshot of these stored variables.
It could be the variables are actually empty.
It could be the variables are not empty, but not stored correctly under the "file" local storage.

Have you arranged the persistent data folder and settings.js correctly?
See the text on github under installation:
A - Persistent data folder.
B - Adjust settings.js.

@albertoanta
Copy link

As you mention F_stored_next_operating_mode is empty, now i remember two weeks ago scheduled Force DHW in nodered dashboard, DHW was done but when it finished it active heat mode. Suspect the same behavior "it sends out the value 0 (zero) which is Heat Only".
Captura de pantalla de 2023-05-11 16-59-51
The first blue area is when DHW force scheduled cycle, the second purple area is compressor runnig in Heat mode, when DHW force finished and previous state (DHW_only) was not restore. Compressor running is drawed in purple. I noticed why is on heating mode where it was at DHW_only mode.

@omenukas
Copy link
Author

I have HA Node-Red Addon installation.
I checked the A and B settings and everything is as described here:
https://github.com/edterbak/NodeRed_Heishamon_control/tree/main/HomeAssistant

When sterilization is not enabled, I did not find the parameter F_stored_next_operating_mode.
Meanwhile, the parameter:
image

When I turn on manually from app force sterilization:
image
image

"F_stored_next_operating_mode" doesn't exist anyway.
I also noticed another nuance - when I manually turned on Force sterilization in the app, I can't turn it off later in the app.
I only turned off sterilization on the pump dashboard.

@edterbak
Copy link
Owner

Ok. Let me digest this ..

The toggle on home screen is different than the schedular function. The toggle does not set F_stored_next_operating_mode.
Ill make it similar soon.

@edterbak
Copy link
Owner

edterbak commented May 11, 2023

I have rewritten the Sterilization code part now.

The toggle on the dashboard is the same as doing a scheduled sterilization.
I have tested it 3x now.

Toggle on: Heat only >> HEAT+DHW, + Sterelization = 1
Toggle on: HEAT+DHW >> Heat only, + Sterelization = 0

Toggle on: Auto(2) >> Auto+DHW(6), + Sterelization = 1
Toggle on: Auto+DHW(6) >> Auto(2), + Sterelization = 0

It should be ok now.
I will upload a version, version 22.29, in a minute

@albertoanta
The Force DHW option is a different topic.
BTW, the toggle does not mean. force a dhw run.
The toggle means, throw away efficiency during a dhw run. I want hot water fast.
Forceful is the better choice of name I would say.
At least, this is what I understood from it.

edterbak added a commit that referenced this issue May 11, 2023
[2023-05-11] v22.29 beta (experimental). Changes:
- [Fix] - Attempt to fix Sterilization issue. #108
edterbak added a commit that referenced this issue May 11, 2023
[2023-05-11] v22.29 beta (experimental). Changes:
- [Fix] - Attempt to fix Sterilization issue. #108
@omenukas
Copy link
Author

Good news!! After installing version 22.29, the pump returned to DHW mode after force sterilization.
Now I will wait until Monday, when the regular sterilization will be done.
Weekly sterilization is set on the pump dashboard. Should it work with this setting or do I need to set the scheduler in the app?

@edterbak
Copy link
Owner

Good news indeed. Thanks.
If you only use the nr schedular, that is sufficient. You do not need the schedules steril task on the wall controller

@omenukas
Copy link
Author

Problem solved

@edterbak
Copy link
Owner

supurb. thanks for confirming !! :D

@omenukas omenukas reopened this Jun 19, 2023
@omenukas
Copy link
Author

supurb. thanks for confirming !! :D

Hello again,
Could you please help in one more place?
I wanted to make an automation in node-red so that towards the evening, while the sun is still shining and the solar power plant is still producing electricity, the heat pump will heat the water.
The script activates "Force DHW" in the heat pump, but returns to "Heating only" when finished.
The solar power plant works independently, it is not connected to the heat pump and only the script controls the pump according to the sensor of the solar power plant.
Maybe this place can be fixed to return to the previous mode after Force DHW?

@edterbak
Copy link
Owner

Hi,
Could you close this issue and make a new one?
the issue is solved here. It was about sterilization mode, and not force dhw.

In the new thread/issue, I do like to have more info on your scenario.
How are you triggering exactly the force dhw. in detail.
What script, what does it do.
What is the state befor the script fires.
etc..
You can share the node (select + export) or use screenshots as well to make it clear what you are doing.

Regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants