Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable conversion (naming convention) #70

Closed
edterbak opened this issue Jan 18, 2023 · 5 comments
Closed

Variable conversion (naming convention) #70

edterbak opened this issue Jan 18, 2023 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@edterbak
Copy link
Owner

edterbak commented Jan 18, 2023

Exponential growth of variable use. To reduce resource impact, group variables.
To keep things clear, start using naming conventions. See image below.

Image

Variable changes are listed below.

MQTT	
	.active								MQTT block enabled/disabled 1,0
	.allow_rtc_onoff			
	.allow_scheduler			
	.allow_solar				
	.block_mode							BLOCK ALL (1) , CUSTOM (2), UNRESTRICTED (3)
	.block_mode_previous						Restore to this block_mode when disabling switch
	.counter				    			Total MQTT messages counter
	.messages_today			    				No. MQTT messages today
	.messages_yesterday		    				No. MQTT messages yesterday
	.message_limit			    				Maximum allowed messages in 24h allow before block will activate

NightReductionWaterTemp
	.current_value							renamed from NightReduction_current_value
	.correction							renamed from NightReduction_correction
	.state								renamed from nightreduction_on_off

NightReductionRoomSetpoint
	.state 								Night reduction room setpoint status (1,0)
	.LOW								renamed from RoomSetpointLOW
	.NORMAL								renamed from RoomSetpointNORMAL

F_ReducePumpSpeed
	.state								Reduce pump speed active 1,0
	.PumpMaxFlowSetting						
	.SavedPumpspeed							Value to restore to when disabled
	.LowSpeed							Value used as low pump speed when active

F_RTC
	.state								RTC main function on/off (1,0)
	.incremental_setpoints_state					incremental_setpoints status of switch. (Renamed from Booster), value 1,0
	.correction_value (Memory Only)					RTC correction (renamed from F_RTC_correction)
	.F1_power_state							function turn on/off heatpump (1,0)
	.F2_OM_state							function change OM heatpump
	.on_off_active							0= waiting to turn heat on. 1= waiting to turn heat off
	.on_off_status							value: 0,1,2

Defrost
	.Counter							Renamed from Defrost_Counter
	.Counter_Today							Renamed from Defrost_Counter_Today
	.Counter_Yesterday						Renamed from Defrost_Counter_Yesterday
@edterbak edterbak added this to the Stable Release (v23.00) milestone Jan 18, 2023
@edterbak edterbak added the enhancement New feature or request label Jan 18, 2023
@edterbak edterbak self-assigned this Jan 21, 2023
@edterbak
Copy link
Owner Author

Deze taak doen vanuit NodeRed zelf, CTRL+F. Dus niet tektfile openen en find+replace all.

Reden is dat je in NR flow voor flow doorloopt en kunt controleren of alle global.get's slim gebundeld zijn of niet. Dit heb je niet als je domweg in notepad find/replace all doet.
Kost meer tijd, maar je doet het in 1x goed.

@edterbak
Copy link
Owner Author

Ik heb een excel gemaakt met alle variabelen en wat dit moet worden.
ik zorg dat het hier komt te staan, zodat we het er over kunnen hebben.
groet

@edterbak
Copy link
Owner Author

xls file gedeeld met maarten via prive repo

@edterbak
Copy link
Owner Author

edterbak commented Feb 2, 2023

Ik heb de XLS file behooooorlijk verbouwd.
ik was een beetje begonnen met de convention, maar door bugs heb ik dit even naar achteren geschoven. Eerst de bugs, daarna pak ik dit weer op.

@edterbak
Copy link
Owner Author

moved to milestone 25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant