Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

staticman failing to create pull request #217

Closed
hendrixjoseph opened this issue Jul 13, 2018 · 12 comments
Closed

staticman failing to create pull request #217

hendrixjoseph opened this issue Jul 13, 2018 · 12 comments

Comments

@hendrixjoseph
Copy link

Steps to reproduce:

  • Go to the Popcorn demo site.
  • Enter a review.
  • Hit submit.

Result: an error dialog appears ("Error Sorry, there was an error with the submission!")

A new branch will be created, but there will be no pull request. For instance, this is the file in the branch when I tried - https://github.com/eduardoboucas/popcorn/blob/staticman_d5564aa0-86cd-11e8-bce9-2fc4fd410763/_data/reviews/entry1531507924416.yml

I notices this on my own blog as well, but got a more detailed response:

{
   "success":false,
   "rawError":{
      "code":403,
      "status":"Forbidden",
      "message":"{\"message\":\"At least one email address must be verified to do that.\",
           \"documentation_url\":\"https://help.github.com/articles/adding-an-email-address-to-your-github-account\"}"
   },
   "errorCode":"GITHUB_CREATING_PR"
}
@MiKatre
Copy link

MiKatre commented Jul 14, 2018

Exact same issue with my two websites using staticman:

{
   "success":false,
   "rawError":{
      "code":403,
      "status":"Forbidden",
      "message":"{\"message\":\"At least one email address must be verified to do that.\",
           \"documentation_url\":\"https://help.github.com/articles/adding-an-email-address-to-your-github-account\"}"
   },
   "errorCode":"GITHUB_CREATING_PR"
}

@hendrixjoseph
Copy link
Author

I just verified that this is the same error from the Popcorn demo site

{
    "success": false,
    "rawError": {
        "code": 403,
        "status": "Forbidden",
        "message": "{\"message\":\"At least one email address must be verified to do that.\",\"documentation_url\":\"https://help.github.com/articles/adding-an-email-address-to-your-github-account\"}"
    },
    "errorCode": "GITHUB_CREATING_PR"
}

is this some change in github's platform, or is there no email associated with staticman?

also, if I go to the GitHub page for @staticmanapp (https://github.com/staticmanapp) I get a 500 server error. it doesn't happen with anyone else's user page

@nfreear
Copy link

nfreear commented Jul 16, 2018

@GonzaloZiadi
Copy link

Facing this same issue as well.

@jloisel
Copy link

jloisel commented Jul 17, 2018

👍 on this. Same issue here.

@eduardoboucas
Copy link
Owner

Something really odd is going on. When I try to sign in to GitHub as staticmanapp (the user account used by the public instance to create the pull requests), I get that 500 page. No additional information whatsoever.

I'll try to find out what's going on, but it's definitely something that changed on the GitHub side.

@Stanko
Copy link

Stanko commented Jul 19, 2018

It seems that bot account has no verified email address set. It is probably security change on the github side. I think verifying email address would probably solve it.

https://help.github.com/articles/verifying-your-email-address/

@eduardoboucas
Copy link
Owner

I thought the email was verified, but apparently that wasn't the case. Anyway, I managed to do this, but I still see a 500 page when I try to access the profile.

Can anyone confirm if the API errors still persist?

Thanks!

@Stanko
Copy link

Stanko commented Jul 19, 2018

@eduardoboucas works here! Thank you for the fast turnaround! 🎉

@hendrixjoseph
Copy link
Author

all good here. @staticmanapp is no longer showing a 500 error for me either https://github.com/staticmanapp

@jloisel
Copy link

jloisel commented Jul 19, 2018

I confirm it's working on our side too.

@eduardoboucas
Copy link
Owner

Great. Thanks all!

caiopavanelli pushed a commit to caiopavanelli/staticman that referenced this issue Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants