Make Tensor generic and add ShapeMap and Rank types #21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to implement the suggested types from #18
The types are the same as the ones in @tensorflow/tfjs-core and should be adapted to what this project requires if necessary.
TODO
ShapeMap[R]
to replace other instances ofArray<any>
At.backward
tril
Some of the other support functions may need to be updated in order to resolve the type errors. It would help to properly define types for the other functions that currently return
any
orArray<any>
. In depth knowledge of how those functions is needed and if the logic is changed we should first add unit tests that can be used to check if the output remains the same for all cases.