Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamically translate typesafe HOCON properties to Hikari properties #36

Closed
dkharrat opened this issue Dec 12, 2014 · 1 comment
Closed

Comments

@dkharrat
Copy link

I'm trying out this plugin and noticed that the preferred way to use it is to reference a properties file in the app's .conf file. In our particular application, we have references to many databases (over 16). I feel that defining a property file for each database is a bit messy and will lead to many files. Ideally, I'd like to have the configuration for our databases all defined in one file (production.conf) using the HOCON syntax.

I could use the Play way of defining the config, but the issue is that I'm limited to what Play defines. Why be constrained to what Play defines? Would it be possible to allow using the actual Hikari properties, and just pass them to the HikariConfig object as is (could be done by getting the property names of the hikari's hocon subtree dynamically).

e.g.

db.default.hikaricp {
  dataSourceClassName="org.postgresql.ds.PGSimpleDataSource"
  dataSource.user=test
  dataSource.password=secret
  dataSource.databaseName=mydb
  dataSource.serverName=localhost
}
@megazord
Copy link
Contributor

Fixed at master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants