alternative classloader strategy #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e, allow to configure at fxlauncher classloader at boot-time and add the new classpath-entries to this classloader. this should avoid problems where the jdk itself does use Class.forName and might not find application-classes due to using the wrong classloader.
|
That's a neat trick :) Thanks a lot! |
Closed
|
Yes, just tested again here and it seems to work. |
|
Perfect. Will do a release soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternatively to creating a classloader for the application at runtime, allow to configure at fxlauncher classloader at boot-time and add the new classpath-entries to this classloader.
This should avoid problems where the jdk itself uses Class.forName (e.g. URLStreamHandler stuff) and might not find application-classes due to using the wrong classloader.
To activate this classloader one needs to add
-Djava.system.class.loader=fxlauncher.FxlauncherClassCloader
to the fxlauncher startup.
Without this argument the current behavior is still in place.