Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bom 1021 #84

Merged
merged 1 commit into from
Mar 31, 2020
Merged

Bom 1021 #84

merged 1 commit into from
Mar 31, 2020

Conversation

Ayub-Khan
Copy link
Contributor

-updated tox and travis
-show deprication warnings

@coveralls
Copy link

coveralls commented Nov 8, 2019

Coverage Status

Coverage increased (+3.5%) to 99.722% when pulling 40a5e3d on BOM-1021 into 302dd1f on master.

'django.contrib.sessions.middleware.SessionMiddleware',
'django.contrib.auth.middleware.AuthenticationMiddleware',
'django.contrib.auth.middleware.SessionAuthenticationMiddleware',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Session verification is enabled and mandatory in Django 1.10 (there’s no way to disable it) regardless of whether or not SessionAuthenticationMiddleware is enabled. In older versions, this protection only applies if django.contrib.auth.middleware.SessionAuthenticationMiddleware is enabled in MIDDLEWARE.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ayub-Khan
Copy link
Contributor Author

@Ayub-Khan
Copy link
Contributor Author

@Ayub-Khan
Copy link
Contributor Author

@dianakhuang dianakhuang force-pushed the BOM-1021 branch 11 times, most recently from adb400c to 704c694 Compare March 31, 2020 17:38
Copy link

@nasthagiri nasthagiri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall.
I had 2 questions - mostly for my own edification in understanding the changes.

tox.ini Outdated Show resolved Hide resolved
test_settings.py Show resolved Hide resolved
-updated tox and travis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants