-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BD-19] Transition to the Elasticsearch 7.8.0 version #104
[BD-19] Transition to the Elasticsearch 7.8.0 version #104
Conversation
Thanks for the pull request, @Golub-Sergey! I've created BLENDED-532 to keep track of it in Jira. More details are on the BD-19 project page. When this pull request is ready, tag your edX technical lead. |
da1a0bb
to
6d218df
Compare
@Golub-Sergey I'm trying to run this locally for testing but having difficulty (CC: @dianakhuang). Would you mind including a write-up of the steps you used to configure this to run in your devstack? I think I'm running the right code/config everywhere (see below), but first, never got results for any queries and now, after some more manual fiddling, get errors. I'm using this devstack branch [1] to run this version of search [2] via this version of platform [3]. |
Hello, @stvstnfrd . Can you please use this version of the edx-platform. I tested locally this changes and it works and searches correctly. This branch was forked from #104 branch. Current version of edx-search lib without platform changes produces errors. |
bec4646
to
6d218df
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Golub-Sergey A few questions/suggestions, but I have this running successfully in my devstack now :)
services: | ||
|
||
test_elasticsearch: | ||
image: elasticsearch:7.8.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hrmm, is there any way to (easily) keep this in sync w/ the value listed in the requirements file(s) below?
Otherwise, this will probably fall out of step.
I'm not sure how/if this is handled elsewhere in the ecosystem...
Not a deal-breaker, just curious...
@stvstnfrd Hello, I recreated pr to platfrom which applies edx-search lib changes to the edx-platform |
You can see the latest CI results over here: https://github.com/edx/edx-platform/pull/24995 Direct link to quality failure: https://build.testeng.edx.org/job/edx-platform-quality-pipeline-pr/19985/Diff_20Quality_20Report/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Golub-Sergey Okay, this looks good to me. Before merge, we'll want to bump the version number in setup.py
. Given these breaking changes, we should probably bump up to a 2.0.0
release. Thoughts?
Thats a good idea. Done. |
Description: transition from es1.5 to es7. Replaces index
courseware_index
with doc_typescourseware_content
andcourse_info
to indexescourseware_content
andcourse_info
Was done:
Code coverage: 99%
Notes: