refactor(promises): consistently return promises from ensure methods

BREAKING CHANGE: Making the callback optional and deprecated. Promises are the preferred way of waiting for the methods to finish. Breaking change because it technically changes the method return value signature. No known repositories are using the return value, luckily. Also updating eslint-related packages so that the linter will stop complaining about object rest/spread issues.
edx · Aug 28, 2019 · 289f782 · 289f782
1 parent 4eb9693
commit 289f782
Show file tree

Hide file tree

Showing 6 changed files with 932 additions and 702 deletions.
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -1,5 +1,6 @@
 {
     "extends": "eslint-config-edx",
+    "parser": "babel-eslint",
     "rules": {
         "import/no-extraneous-dependencies": [
             "error",

diff --git a/.gitignore b/.gitignore
@@ -2,3 +2,4 @@
 coverage
 dist
 node_modules
+/.vscode