Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Table): add aria-hidden to sort icons in Table #76

Merged
merged 1 commit into from
Nov 20, 2017
Merged

fix(Table): add aria-hidden to sort icons in Table #76

merged 1 commit into from
Nov 20, 2017

Conversation

MichaelRoytman
Copy link
Contributor

add aria-hidden tag to the table headings of sortable columns in a sortable Table so icons are not
read aloud to screen-reader users

@MichaelRoytman
fix(Table): add aria-hidden to sort icons in Table
e36dd4b 
add aria-hidden tag to the table headings of sortable columns in a sortable Table so icons are not
read aloud to screen-reader users
@coveralls
Copy link

coveralls commented Nov 17, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 99.501% when pulling e36dd4b on mroytman/hide-sort-icons into 9690fda on master.

@MichaelRoytman
Copy link
Contributor Author

Please review this PR at your convenience.

jaebradley
jaebradley reviewed Nov 17, 2017
View reviewed changes
Copy link
Contributor

@jaebradley jaebradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks pretty straightforward

(nice commit message 😉 )

@MichaelRoytman MichaelRoytman merged commit c9e0581 into master Nov 20, 2017
@MichaelRoytman MichaelRoytman deleted the mroytman/hide-sort-icons branch November 20, 2017 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaebradley jaebradley jaebradley left review comments

@arizzitano arizzitano arizzitano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MichaelRoytman @coveralls @arizzitano @jaebradley