-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added CardSelect component #808
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zamanafzal
force-pushed
the
iahmad/ENT-4799
branch
from
August 31, 2021 16:39
2355855
to
8ac87f6
Compare
irfanuddinahmad
force-pushed
the
iahmad/ENT-4799
branch
2 times, most recently
from
September 1, 2021 15:12
2945913
to
a6f40c1
Compare
irfanuddinahmad
force-pushed
the
iahmad/ENT-4799
branch
from
September 1, 2021 15:43
a6f40c1
to
e36537c
Compare
zamanafzal
reviewed
Sep 2, 2021
zamanafzal
reviewed
Sep 2, 2021
zamanafzal
reviewed
Sep 2, 2021
irfanuddinahmad
force-pushed
the
iahmad/ENT-4799
branch
3 times, most recently
from
September 3, 2021 11:50
4852eb2
to
ce4891c
Compare
irfanuddinahmad
requested review from
zamanafzal,
wittjeff and
adamstankiewicz
September 3, 2021 12:29
irfanuddinahmad
force-pushed
the
iahmad/ENT-4799
branch
from
September 3, 2021 12:37
ce4891c
to
047b629
Compare
irfanuddinahmad
changed the title
WIP: feat: Added CardSelect component
feat: Added CardSelect component
Sep 3, 2021
irfanuddinahmad
force-pushed
the
iahmad/ENT-4799
branch
from
September 3, 2021 12:46
047b629
to
59d2a74
Compare
zamanafzal
reviewed
Sep 3, 2021
Great Work 💯 |
irfanuddinahmad
force-pushed
the
iahmad/ENT-4799
branch
from
September 7, 2021 10:20
59d2a74
to
bf21679
Compare
zamanafzal
approved these changes
Sep 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
HammadAhmadWaqas
approved these changes
Sep 7, 2021
sameenfatima78
approved these changes
Sep 7, 2021
moconnell1453
approved these changes
Sep 7, 2021
🎉 This PR is included in version 16.13.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
adamstankiewicz
added a commit
that referenced
this pull request
Sep 20, 2021
This reverts commit d8dec97.
adamstankiewicz
added a commit
that referenced
this pull request
Sep 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This PR adds a radio selectable card form group.
JIRA: https://openedx.atlassian.net/browse/ENT-4799