Update or replace rest-condition dependency

[jmbowman]

We use the rest-condition package in edx/completion, edx/course-discovery, edx/credentials, edx/demographics, edx/ecommerce, edx/edx-analytics-dashboard, edx/edx-analytics-data-api, edx/edx-drf-extensions, edx/edx-enterprise, edx/edx-enterprise-data, edx/edx-notes-api, edx/edx-organizations, edx/edx-platform, edx/edx-proctoring, edx/edx-rbac, edx/edx-val, edx/edx-when, edx/enterprise-catalog, edx/license-manager, edx/portal-designer, edx/registrar, and edx/video-encode-manager (in some cases, only via use of another package in that list of repos). But it hasn't yet added support for Django 3.2, and in fact hasn't been updated since January 2019. Please follow the guidance in https://openedx.atlassian.net/wiki/spaces/AC/pages/3036972032/Handling+Outdated+Dependencies to resolve the problem this poses for the Open edX Django 3.2 upgrade.

[xitij2000]

@jmbowman I've run a quick search across the codebase and I see that while rest-condition is listed as a requirement, it no longer seems to be imported anywhere other than in edx-platform.

Additionally, I see that composing permissions has been supported in DRF since v3.9 : https://www.django-rest-framework.org/community/3.9-announcement/#composable-permission-classes

I can take this on, remove the requirement across all usages and switch edx-platform to using DRF-based composition directly.

[xitij2000]

edx-platform PR: https://github.com/edx/edx-platform/pull/28663
edx-drf-extensions PR: openedx/edx-drf-extensions#202

[natabene]

@xitij2000 Thanks so much for an update.

[xitij2000]

The base PRs have been idle for a while. If they are not going to be worked on I can pick them up.

[regisb]

I guess this issue should be assigned to @xitij2000 right @natabene?

[natabene]

@regisb Absolutely, thanks for letting me know.

[xitij2000]

completion: openedx/completion#160
course-discovery: openedx/course-discovery#3169

[xitij2000]

@regisb I've run upgrade on a few more repos and added links here. At this point for most repos automated dependency updates should fix things, and those will be part of any django 3.2 upgrade anyway.

I am on leave for a few days so won't be able to look into this for a bit. My quick scan of the repos I have checked out locally shows that they all use rest-condition via edx-drf-extensions. So there may be nothing more to do here.

[natabene]

@xitij2000 Thanks so much for an update!

[xitij2000]

• edx/ecommerce: https://github.com/edx/ecommerce/pull/3527

Completed:

• edx/edx-enterprise-data: feat: Shifted CI from Travis to Github Actions openedx/edx-enterprise-data#273
• edx/edx-enterprise: chore: upgrade dependencies openedx/edx-enterprise#1393
• edx/edx-analytics-data-api: https://github.com/edx/edx-analytics-data-api/pull/501
• edx/completion: chore: Upgrade dependencies and fix code quality issues openedx/completion#160
• edx/course-discovery: fix: use github has for django-elasticsearch-dsl openedx/course-discovery#3188
• edx/credentials: chore: Upgrade requirements openedx/credentials#1376
• edx/demographics: No access
• edx/edx-analytics-dashboard: https://github.com/edx/edx-analytics-dashboard/pull/1203
• edx/edx-drf-extensions: feat!: Add support for permissions composed using DRF openedx/edx-drf-extensions#202
• edx/edx-organizations: Python Requirements Update openedx/edx-organizations#215
• edx/edx-platform: https://github.com/edx/edx-platform/pull/28663
• edx/edx-proctoring: Python Requirements Update openedx/edx-proctoring#976
• edx/edx-rbac: Python Requirements Update openedx/edx-rbac#114
• edx/edx-when: Python Requirements Update openedx/edx-when#114
• edx/enterprise-catalog: ENT-4987 | pyjwt 2.1.0 upgrade (Cpappas/pyjwt210 branch for conflict resolution) openedx/enterprise-catalog#327
• edx/license-manager: feat: upgrade pyjwt to 2.1.0 openedx/license-manager#300
• edx/portal-designer: Python Requirements Update portal-designer#151
• edx/registrar: Python Requirements Update openedx-unsupported/registrar#452
• edx/video-encode-manager: No access
• edx/edx-val: test: add provider verification CI job openedx/edx-val#326
• edx/edx-notes-api: feat: upgrade edx-drf-extensions and pyjwt openedx/edx-notes-api#264

[natabene]

@xitij2000 Thank you for an update, this is beautiful! @awais786 We can use the list @xitij2000 made to see what is still outstanding for our team.

[Jawayria]

@natabene @xitij2000 I've checked in edx/demographics and edx/video-encode-manager. We've edx-drf-extensions 8.0.0 in master branches for both of them.

[xitij2000]

I might not have time to follow through fully with openedx/edx-enterprise#1393 which is the PR to upgrade edx-enterprise. Upgrading dependencies causes a lot of linting errors due to f-strings etc, and running a normal pyupgrade isn't sufficient.

[xitij2000]

I think that PR is mostly ready. However, it seems pretty large after running pyupgrade and performing other cleanup.
Not sure what the process is for a PR like that.

[natabene]

@xitij2000 Thanks for your comment, we will review.

[mikix]

I hope you don't mind, but I took the liberty of editing the tracking comment above to mark that edx-notes-api is now upgraded.

[xitij2000]

I hope you don't mind, but I took the liberty of editing the tracking comment above to mark that edx-notes-api is now upgraded.

Thanks!