More accurate test skip messages

For window.location changes that we can't currently test with the test package. Paired with @terrasea #102
eee-c · May 21, 2016 · 399d272 · 399d272
1 parent 64d0091
commit 399d272
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 10 deletions.
diff --git a/test/full/copy_dialog_test.dart b/test/full/copy_dialog_test.dart
@@ -245,11 +245,8 @@ copy_dialog_tests() {
    });
 
    test('leaves snapshot mode', () {
-     expect(
-       window.location.hash,
-       ''
-     );
-   }, skip: "Unsure that it's possible to test this");
+     expect(window.location.search, '');
+   }, skip: "Cannot test window.location changes with current test runner");
  });
 
 }
diff --git a/test/full_test.dart b/test/full_test.dart
@@ -212,11 +212,8 @@ full_tests() {
         queryWithContent('button', 'Leave Snapshot Mode').
         click();
 
-      expect(
-        window.location.hash,
-        ''
-      );
-    }, skip: "Unsure if it's possible to test this");
+      expect(window.location.search, '');
+    }, skip: 'Cannot test window.location changes with current test runner');
 
     test("menu only includes Open, Make a Copy, and Help", (){
       helpers.click('button', text: '☰');