Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to the new test package #102

Closed
eee-c opened this issue Mar 4, 2015 · 0 comments
Closed

Switch to the new test package #102

eee-c opened this issue Mar 4, 2015 · 0 comments
Assignees
@eee-c
Labels
bug

Comments

@eee-c
Copy link
Owner

eee-c commented Mar 4, 2015

The tests work in content_shell with unittest 0.11.4, but not the latest. We temporarily pegged the version 0.11.4 in pubspec.yaml, but need a more permanent solution.

Need to switch to new test package.

  • Re-enable the polymer tests.
  • Re-enable the html5 tests.
  • Re-enable the query param mode tests in full_test.dart
@eee-c eee-c added the bug label Mar 4, 2015
eee-c added a commit that referenced this issue Mar 4, 2015
@eee-c
Peg unittest to 0.11.4
f2cff5c 
Last known version to work with content_shell (or at least our
test runner).

Paired with @kelegorm

#102
@eee-c eee-c self-assigned this Jul 10, 2015
eee-c added a commit that referenced this issue Jul 10, 2015
@eee-c
Remove unused variable
07c903a 
Paired with @ashokdudhade

#102
@eee-c eee-c changed the title Fix test_runner.sh for latest unittest Switch to the new test package Jul 10, 2015
eee-c added a commit that referenced this issue Jul 10, 2015
@eee-c
First pass at moving tests to test package
c4b0c50 
Paired with @ashokdudhade

#102
eee-c added a commit that referenced this issue Aug 23, 2015
@eee-c
Fix editor tests and test_runner
327c509 
Paired with @terrasea

#102
eee-c added a commit that referenced this issue Aug 23, 2015
@eee-c
Not on where to start next
92ded48 
Paired with @terrasea

#102
eee-c added a commit that referenced this issue Sep 30, 2015
@eee-c
Fix return type of content setter
f24698c 
Paired with TheOtakuGamerSilverstar

#102
eee-c added a commit that referenced this issue Nov 8, 2015
@eee-c
Get working tests back in the suite
530f01f 
Not all are passing, but these at least run under content shell as well
as from the browser.

Paired with @terrasea

#102
eee-c added a commit that referenced this issue Dec 27, 2015
@eee-c
Dart analyzer output is now one fewer lines
4fc0f38 
Paired with @terrasea

#102
eee-c added a commit that referenced this issue Dec 27, 2015
@eee-c
Notes for running in debugger from pub test
99f642e 
Test passes, but we're stuck in some infinite loop afterwards.

Paired with @terrasea

#102
eee-c added a commit that referenced this issue Dec 27, 2015
@eee-c
Trying to go back to old unittest
134857e 
This is still not working -- it seems like it is not running all tests, so
produces no output.

Would be nice to get this running and/or supply the Dart folks with a small
test case to get the new test package fixed for us.

Paired with @terrasea

#102
eee-c added a commit that referenced this issue Feb 15, 2016
@eee-c
Identified test problem as window.location related
d3886fa 
Currently skipping those tests, but now we should be able to track them
down.

Paired with @terrasea

[#102]
eee-c added a commit that referenced this issue Feb 15, 2016
@eee-c
Restore (but skip) ICE param mode tests
d2f977e 
We need a testing solution for all of these.

Paired with @terrasea

[#102]
eee-c added a commit that referenced this issue May 16, 2016
@eee-c
Identify test package hash as source of trouble
892a38c 
The test package sends a bunch of info to individual tests in
the window location hash, so our mucking with it interfers
with the tests. Need to find a way around that, but still
need to be able to test things like the removal of hash strings
when copy dialog closes.

Paired with @kgrz

#102
eee-c added a commit that referenced this issue May 19, 2016
@eee-c
Test runner workaround: new "mode" param for Full
7d10050 
Seems like we have no choice but to require mode (snapshot, game, edit-only)
settings to come from the outside. Not horrible, but a bit of a bummer that
the test runner is forcing us to change design.

I know, I know, it's a unit test runner, not an acceptance testing
framework, blah, blah, blah. A bummer regardless

All tests passing, though a few are marked skip for further review.

#102
eee-c added a commit that referenced this issue May 21, 2016
@eee-c
Full editor requires any compressed content in constructor
64d0091 
Used to get this from window.location.hash, but the default test runner mucks
with that variable.

Paired with @terrasea

#102
eee-c added a commit that referenced this issue May 21, 2016
@eee-c
More accurate test skip messages
399d272 
For window.location changes that we can't currently test with the
test package.

Paired with @terrasea

#102
eee-c added a commit that referenced this issue May 21, 2016
@eee-c
Restore the analyzer in the test_runner shell script
ef6a98d 
#102
@eee-c eee-c closed this as completed in b81a060 May 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eee-c eee-c

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eee-c