Add QuantLib as an explicit submodule, tagged at v1.17 #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igitur
force-pushed
the
quantlib-as-submodule
branch
from
1659da4
to
49e81eb
Compare
igitur
force-pushed
the
quantlib-as-submodule
branch
from
49e81eb
to
8d7d88f
Compare
|
I tried submodules once and was not an immediate fan of them. Also on linux it is not suitable to have QuantLib as a subdirectory of QuantLibAddin. I'm open to discussion but at first glance I would prefer not to use a submodule. |
|
OK, let me play around on Linux with it too. I just tried it out on Windows initially. But I can see how, on Linux, it's maybe just easier to have a symbolic link to the actual QuantLib directory. On Windows, that's possible, but a bit harder. |
|
Closing for now. |
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Eric,
This just a suggestion to make QuantLib an explicit submodule of this repo. In this I'm basing this PR on v1.17 and therefor the QuantLib submodule is also refereced against the v1.17 release.
This will avoid having to manually clone and checkout the appropriate QuantLib version.
Can you see any disadvantages of this approach?