Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement: rmbatch #107

Closed
djmbritt opened this issue Jan 5, 2023 · 1 comment
Closed

Implement: rmbatch #107

djmbritt opened this issue Jan 5, 2023 · 1 comment
Labels
bounty These issues get added to the bounty board

Comments

@djmbritt
Copy link
Member

djmbritt commented Jan 5, 2023

Feature

Given a batchid the corresponding batch needs to be deleted.

Description

What should the limitations be?
Only the owner of the batch should be able to delete the batch.
What should happen with the rest of the efx stored in the batch?

This also raises the question about what to do with the funds in the batch.
What if there are users who have completed tasks in the batch, but have not yet claimed their task reward.
Where will the funds be stored until the user has claimed the task reward?

Or maybe the requester can only pause the batch, until all users have claimed their rewards.

Steps

The implementation should be relatively easy, there should be a couple of other examples where this is already implemented. Look at this one as an example:

void force::rmcampaign(uint32_t campaign_id, vaccount::vaddress owner, vaccount::sig sig) {

@djmbritt djmbritt added the bounty These issues get added to the bounty board label Jan 5, 2023
@jeisses
Copy link
Member

jeisses commented Jan 5, 2023

This action already exists, but we need a mechanism to refund the EFX. @jabbarn is working on this ticket: #87

Removing a batch also has the upside that we can remove the submissions: #94

I'm closing this ticket in favor of those 2

@jeisses jeisses closed this as completed Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bounty These issues get added to the bounty board
Projects
None yet
Development

No branches or pull requests

2 participants