Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish refactoring how we map filters to actions #50

Closed
dtauerbach opened this issue Nov 1, 2013 · 2 comments
Closed

Finish refactoring how we map filters to actions #50

dtauerbach opened this issue Nov 1, 2013 · 2 comments
Assignees

Comments

@dtauerbach
Copy link
Contributor

Right now the actual blocking and subscription lists have been refactored, but not the popup.js logic. We need to think carefully about how to refactor.

  1. Should there be an Action object, or is it OK to just have an enum and represent actions by string (e.g. "cookieblock")?
  2. We should change getBlockedData in background.js to return to actions themselves to popup.js, not the list of subscriptions which fired/didn't fire.
  3. We need to somehow be able to determine if a user changed a setting. Right now if I load something in Tab1, then browse to Tab2, it's possible that something will have been added to the frequencyHeuristic subscription from Tab1 that was previously unblocked. Then if I go back to Tab1, we need to update, else it could look like the user changed.
@ghost ghost assigned dtauerbach Nov 1, 2013
@dtauerbach
Copy link
Contributor Author

Working in fix-lists branch.

For 1, represented as a sort of subscription list "lastaction" in the dict that tracks what we are blocking by tab; this is done. 2 is done.

For 3, the idea is for user-set actions for domains to have a css class, so we can, for example, display a little lock or something indicating the user has locked this setting. User settings will always override extension permanently, so if a use changes a setting for a domain to being blocked, it will stay that way until the user changes it back. A future todo is to allow the user to return responsibility to the extension somehow for a particular domain.

@dtauerbach
Copy link
Contributor Author

Done with merging "fix-lists" branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant