New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GID must be specified when UID is specified #2

Closed

totycro opened this issue Aug 6, 2020 · 1 comment

Contributor

totycro commented Aug 6, 2020

Hi!

Thanks for providing this very convenient docker image!

I just noticed a minor issue: If you specify the UID, but not the GID, then the mount actually fails.
The first problem is here, where adduser fails due to GID being 0, so you get adduser: unknown group 0:
https://github.com/efrecon/docker-s3fs-client/blob/master/docker-entrypoint.sh#L48

Therefore the user is not created and the subsequent commands fail.

This is not really a bug, but it might be nice to e.g. get a more precise error message or set GID to some default value.

The text was updated successfully, but these errors were encountered:

Owner

efrecon commented Jan 19, 2021

You fixed it, it's merged! So I close this. Thanks again.

efrecon closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment