Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong calculations of BeamWeight_discrete and BeamWeight_relative #7

Closed
3 tasks done
egavazzi opened this issue Aug 1, 2023 · 2 comments
Closed
3 tasks done

Wrong calculations of BeamWeight_discrete and BeamWeight_relative #7

egavazzi opened this issue Aug 1, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@egavazzi
Copy link
Owner

egavazzi commented Aug 1, 2023 •
edited
Loading

The value of BeamWeight_discrete and BeamWeight_relative are wrong because they are calculated from thetha2BeamW which is calculated wrong in the Matlab code.

Pmu2mup is also possibly wrong.

TO DO:

  • fix BeamWeight_discrete
  • fix BeamWeight_relative
  • check and fix Pmu2mup if needed
@egavazzi
Copy link
Owner Author

egavazzi commented Aug 1, 2023 •
edited
Loading

The problem with BeamWeight_discrete is fixed in 573f14c. Comparisons have shown that BeamWeight_discrete and BeamWeight_continuous are actually equal (once BeamWeight_discrete is calculated correctly). So we just switch eveything to BeamWeight_continuous which we just renamed BeamWeight.

@egavazzi egavazzi added the bug Something isn't working label Aug 1, 2023
@egavazzi
Copy link
Owner Author

egavazzi commented Aug 1, 2023 •
edited
Loading

Problems BeamWeight_relative and Pmu2mup should be fixed in the Matlab code by egavazzi/AURORA@bfbc84e. by #8. The Matlab code seems to have some intrinsic calculation errors.

@egavazzi egavazzi closed this as completed Aug 1, 2023
@egavazzi egavazzi mentioned this issue Aug 1, 2023
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@egavazzi