Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS updateStar toggle #11

Open
egglestn opened this issue Sep 22, 2021 · 0 comments
Open

JS updateStar toggle #11

egglestn opened this issue Sep 22, 2021 · 0 comments

Comments

@egglestn
Copy link
Owner

egglestn commented Sep 22, 2021

In JS updateStar

The toggle on the last line reverses the remove a few lines above. It works fine for different values, but if you click the same score twice, it will stay selected. In effect, once you have clicked, you can never not select a score value.

One approach is to only fire the remove if the score value is different. Alternative approaches welcome, as long as the result works and is fairly succinct

@egglestn egglestn changed the title JS updateStar improvements JS updateStar toggle Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant