Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stats inactivity is set at 5 sec; seems too much #3

Closed
egobillot opened this issue Jan 8, 2020 · 0 comments
Closed

stats inactivity is set at 5 sec; seems too much #3

egobillot opened this issue Jan 8, 2020 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@egobillot
Copy link
Owner

stats inactivity threshold is set at 5 sec; seems too much

Inactive stats are cleared in the ebpf map

An inactive stats related to a process is a stats not updated after a given amount of time. In order to free the ebpf map entries, we clear the inactive stats as it is less likely to have concurrency of this data.
This design is a workaround to avoid non atomicity of operations on eBPF maps. The less we touch the map, the better is the atomicity (but not guaranteed)

So far the inactivity threshold is set a 5 secs. This is a bit too much.
Let's try 1 second; 1 second is already an eternity.
It will put more pressure on old stats in map:

  • we will save cpu
  • we do not take too many risks
@egobillot egobillot added the enhancement New feature or request label Jan 8, 2020
@egobillot egobillot self-assigned this Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant