Skip to content
This repository has been archived by the owner on Dec 6, 2021. It is now read-only.

fix: add regexp to allowed type of options.transpileModules #654

Merged
merged 1 commit into from
Dec 13, 2019
Merged

fix: add regexp to allowed type of options.transpileModules #654

merged 1 commit into from
Dec 13, 2019

Conversation

magicdawn
Copy link
Contributor

accroding to this https://github.com/egoist/poi/blob/master/core/poi/lib/plugins/config-babel.js#L53-L54
regexp is allowed, AND regexp should be allowd like vue.config.js
but validations fail when regexp is passed

use case

package manager like cnpm use symlink
like prettier module resolve to node_modules/_prettier@1.19.1@prettier

$ ll node_modules/prettier
lrwxr-xr-x  1 magicdawn  staff    25B 12  9 23:19 node_modules/prettier -> _prettier@1.19.1@prettier

regexp can be used to match this /prettier/

@egoist
Copy link
Owner

egoist commented Dec 13, 2019

Can you update the docs as well? https://poi.js.org/config.html#babel-transpilemodules

@magicdawn
Copy link
Contributor Author

docs updated: poi-bundler/website#22

@egoist egoist merged commit 966efff into egoist:master Dec 13, 2019
@magicdawn magicdawn deleted the fix-option-transpile-module-validate branch December 13, 2019 15:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants