Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devDependencies are bundled even if they are in peerDependencies as well #998

Open
IanVS opened this issue Sep 13, 2023 · 0 comments
Open

Comments

@IanVS
Copy link
Contributor

IanVS commented Sep 13, 2023

According to the readme:

By default tsup bundles all import-ed modules but dependencies and peerDependencies in your package.json are always excluded.

So, I would think that if peerDependencies are always excluded, then if I specify a dependency in both devDependencies and peerDependencies (meaning, it's a peer dependency, but when I'm working on developing the package, I also want it to be installed), then it should not be bundled.

But, this is not the behavior I am seeing. Instead, the dependency is bundled into the build, unless I explicitly add it to externals. Is this intentional, or a bug? If it's intentional, maybe the README can be clarified to avoid such confusion?

Upvote & Fund

  • We're using Polar.sh so you can upvote and help fund this issue.
  • We receive the funding once the issue is completed & confirmed by you.
  • Thank you in advance for helping prioritize & fund our backlog.
Fund with Polar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant