Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strict Length Validation for Local is valid when split by numbers #236

Closed
ghost opened this issue Feb 26, 2020 · 3 comments
Closed

Strict Length Validation for Local is valid when split by numbers #236

ghost opened this issue Feb 26, 2020 · 3 comments
Labels

Comments

@ghost
Copy link

ghost commented Feb 26, 2020

Using the laravel form validation set to strict mode we are coming accross an issue with length checking.

It seems like numbers chars are acting as a divider causing the the second half to validate successfully as it's then under the char limit.

Case 1
aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa@example.com
Expected: Invalid
Result: Invalid

Case 2
a5aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa@example.com
Expected: Invalid
Result: Valid

Case 3
aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa@example.com
Expected: Valid
Result: Valid

@ghost ghost changed the title Strict Length Validation for Local is split by numbers Strict Length Validation for Local is valid when split by numbers Feb 26, 2020
@egulias egulias added the bug label Mar 2, 2020
@egulias
Copy link
Owner

egulias commented Mar 2, 2020

Hi @henrydennis-sonin , thanks for reporting.
Tha's a weird bug!
Would you mind submitting a failing unit test with the second case please?

@ghost
Copy link
Author

ghost commented Mar 3, 2020

Hey @egulias. Just looked at creating the test. Unfortunatly I cannot replicate the failing issue through unit tests. Perhaps it is an issue with laravel's integration.

@marmichalski
Copy link
Contributor

I believe this has been fixed in: https://github.com/egulias/EmailValidator/pull/233/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants