Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About ex_20_4_extended #13

Open
JohnLocke opened this issue May 13, 2024 · 4 comments
Open

About ex_20_4_extended #13

JohnLocke opened this issue May 13, 2024 · 4 comments

Comments

@JohnLocke
Copy link

Hi Eric,

I hope you're doing well. You mentioned that it require a form element on the new_topic page that allows the user to change a topic from private to public. But it wasn't reflected in the repository here. Could you please confirm if this update has been committed?

Thank you very much for your attention to this matter.

@ehmatthes
Copy link
Owner

Hi John,

We need form element to show up on the new_topic page, but that doesn't require a change to that page's template. The necessary change is here. When Django builds the form based on the Topic model, it should include an element for the public field.

If you're not seeing a checkbox for making the topic public after making that change, please let me know.

@JohnLocke
Copy link
Author

Hi Eric,

Thank you so much, it works out perfectly.

Additionally, I would like to make a small suggestion: when using Platform.sh on a Windows system, the instructions in the book (as shown in the first image) can be a bit confusing. The inclusion of "(ll_env)" might make it seem like the command should be run in the virtual environment within the CMD, but when running Platform.sh on Windows under WSL, it looks more like the second image. This caused me some confusion and took a bit of time to figure out.
image1
image2

Thanks again for your help. I finally finished reading the book and completed all the code.

@ehmatthes
Copy link
Owner

I'm glad to hear you made it all the way through, it's a lot of material to cover. :)

Is that a Windows/WSL thing, or is that related to PyCharm? Did you make the virtual environment, or did PyCharm make one for you?

@JohnLocke
Copy link
Author

Thank you for writing such a helpful book for Python beginners.

This is not related to PyCharm. I created and activated the virtual environment in CMD using the following commands:
python -m venv ll_env
ll_env\Scripts\activate

What I meant was that all the command lines before using Platform.sh were executed in CMD. After activating the virtual environment, CMD looked like what is shown in the picture, with "(ll_env)" at the beginning. However, when running Platform.sh on Windows, the command line needs to be executed in the WSL Ubuntu environment, where it does not display "(ll_env)".
1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants