Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log level of: "An error occurred while sending events: [Errno 104] Connection reset by peer" #71

Closed
istvan-derda opened this issue Mar 30, 2022 · 2 comments

Comments

@istvan-derda
Copy link

Hey Enrico,
first, thank you for this amazing library! Great to see people putting time and effort in open-source software.

Now my Issue:
It seems, that something is not perfect with the network in our QA-Environment, I get a lot of "An error occurred while sending events: [Errno 104] Connection reset by peer" from your library (worker.py line 216). Since you took care of handling this well, this is not a big problem. The logs are put back in the queue and are sent immediately after, when the connection is back.

My request:
Since the error is handled in the code, can we lower the log level of these messages? I only want Errors logged, if something in my application is actually broken. So I would propose to change the log level of these messages to WARN.

Reasoning:
Nothing is broken, there is just some networking hiccup, that is handled by the library. Logged Errors like these distract us from seeing, when something is actually broken.

If you like, I can open a Pull-Request to propose a solution.

Yours
István

@istvan-derda istvan-derda changed the title Loglevel of: "An error occurred while sending events: [Errno 104] Connection reset by peer" Log level of: "An error occurred while sending events: [Errno 104] Connection reset by peer" Mar 30, 2022
@eht16 eht16 closed this as completed in 8994632 Apr 3, 2022
@eht16
Copy link
Owner

eht16 commented Apr 3, 2022

Hey Enrico, first, thank you for this amazing library! Great to see people putting time and effort in open-source software.

Glad you like it!

My request: Since the error is handled in the code, can we lower the log level of these messages? I only want Errors logged, if something in my application is actually broken. So I would propose to change the log level of these messages to WARN.

Good idea. I changed the log level for network related errors to WARNING.
Included in the new release 2.4.0.

@istvan-derda
Copy link
Author

Thank you for the quick response :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants