Notification queue #11
Conversation
|
Hi, I dig the feature. One question I saw after a quick first glance. Once the queue is dequeued, won't it then display ALL notifications that have been queued, not just the next 6 or however many have been configured? |
|
Nope, it still stays within whatever limit was set. It simply uses the next item in queue as each item closes. Try opening limit-example.htm and clicking the input button like 100 or so times :) You'll see that it only fills up the limit. Hope this helps, Thanks, -Scott |
| @@ -48,8 +49,8 @@ $.widget("ech.notify", { | |||
| tpl = $(tpl).removeClass("ui-notify-message-style").wrap("<div></div>").parent().html(); | |||
| } | |||
|
|
|||
| // return a new notification instance | |||
| return new $.ech.notify.instance(this)._create(msg, $.extend({}, this.options, opts), tpl); | |||
| $.ech.notify.openNotifications = $.ech.notify.openNotifications || 0; | |||
There was a problem hiding this comment.
Can you change this to this.openNotifications = this.openNotifications || 0 ?
|
Good deal. I made some line comments just for consistency. If you can update those & make sure it still functions properly (i.e., my comments didn't break anything) I'll merge it in. thx! |
…xample to index.htm to show that it works with the other examples. Updated minified JavaScript to reflect the changes.
|
Hopefully this is what you're after. :) |
|
Yup that was a typo on my part. |
| this.element.fadeTo(speed, 0).slideUp(speed, function(){ | ||
| self._trigger("close"); | ||
| self.isOpen = false; | ||
| self.element.remove(); |
There was a problem hiding this comment.
^ Not sure if you noticed this little change I sort of snuck in, but I think this is pretty important because the user could theoretically end up with thousands of unused DOM elements, each with an instance of notify() stored in memory. Could possibly cause memory issues if a user keeps the window open for days and never refreshes the page. Thoughts?
Your notification plugin is the best I've been able to find so far, but it was missing one key feature that we required in order to use it. I have resolved this issue in my fork.
This fork allows the plugin user to limit the amount of notifications visible at one time. The notifications that have been created after this limit has been reached are displayed in order (first in first out) when the previous notification(s) are closed.
Hope you like it :)
-Scott