Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add surface ID member to edm4eic::TrackPoint #39

Closed
tylerkutz opened this issue Aug 10, 2023 · 4 comments · Fixed by #41
Closed

Add surface ID member to edm4eic::TrackPoint #39

tylerkutz opened this issue Aug 10, 2023 · 4 comments · Fixed by #41

Comments

@tylerkutz
Copy link
Contributor

For the purposes of track projections, it would be useful to add a member to TrackPoint that could be used to store the name/ID of the detector/surface the track was projected to.

The simplest solution would be an integer member that could store the detector ID as defined in https://github.com/eic/epic/blob/main/compact/definitions.xml.
@veprbl
Copy link
Member

veprbl commented Aug 11, 2023

cc @c-dilks regarding the projection business

@wdconinc
Copy link
Contributor

Likely you want the acts surface id, right?

@tylerkutz
Copy link
Contributor Author

Following this discussion on Mattermost, it was my plan to populate this field with the detector IDs defined here.

However, I am having issues with the implementation (see new EICrecon branch and explanation of the problem)

@c-dilks
Copy link
Member

c-dilks commented Aug 11, 2023

cc @c-dilks regarding the projection business

I'm not sure how we can take advantage of this feature for our particular use cases in the RICHes, but good to keep in mind in case we ever need this. CC @chchatte92 @alexander-kiselev @kkauder

@tylerkutz tylerkutz linked a pull request Aug 11, 2023 that will close this issue
39 add surface id member to edm4eictrackpoint #41
Merged
1 task
@tylerkutz tylerkutz mentioned this issue Aug 11, 2023
Merged
1 task
@sly2j sly2j closed this as completed in #41 Aug 31, 2023
sly2j pushed a commit that referenced this issue Aug 31, 2023
@tylerkutz
39 add surface id member to edm4eictrackpoint (#41)
de6035f 
### Briefly, what does this PR introduce?
This adds two data members to TrackPoint to identify the detector
and surface on which the TrackPoint lies (implemented for track
projections but could be used more generally).

This change replaces the original change which added a single 32-bit
integer. This was done following a discussion in the S&C meeting on
August 23, 2023. Summary of proposed options can be [found
here](https://indico.bnl.gov/event/20352/contributions/80021/attachments/49313/84184/followup_edm4eic_trackpoint_PR%20copy.pdf).

### What kind of change does this PR introduce?
- [x] New feature (issue #39)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

39 add surface id member to edm4eictrackpoint eic/EDM4eic
4 participants
@veprbl @wdconinc @tylerkutz @c-dilks