Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break up Cluster::clusterShape into named fields #85

Open
veprbl opened this issue Jul 7, 2024 · 1 comment
Open

Break up Cluster::clusterShape into named fields #85

veprbl opened this issue Jul 7, 2024 · 1 comment

Comments

@veprbl
Copy link
Member

veprbl commented Jul 7, 2024

The clusterShape vector member had become a dumping ground for additional values that bypass EDM review procedure

- float shapeParameters // Should be set in metadata, for now it's a list of -- radius [mm], dispersion [mm], 2 entries for theta-phi widths [rad], 3 entries for x-y-z widths [mm].

In addition to that, accessing values by index is confusing to our users. We should migrate away from this approach.

See also eic/EICrecon#1511

@ruse-traveler
Copy link

I'd like to second this: it's a bit embarrassing, but I keep forgetting we have this information stored 😓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants