Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid creating repetitive logical volumes for sampling calorimeters #537

Open
3 tasks
veprbl opened this issue Sep 26, 2023 · 0 comments
Open
3 tasks

Avoid creating repetitive logical volumes for sampling calorimeters #537

veprbl opened this issue Sep 26, 2023 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed topic: simulation

Comments

@veprbl
Copy link
Member

veprbl commented Sep 26, 2023

Ideally, you create the logical layer volume once and place it several times. The flow would be:

  • Create logical layer volume
  • Loop over slices
    • Create logical slice volume
    • Place logical slice volume inside logical layer volume
  • Loop over layers
    • Place logical layer volume in the logical envelope volume
  • Place logical envelope volume in the detector's mother volume

Originally posted by @veprbl in #534 (comment)

Files affected

  • src/InsertCalorimeter_geo.cpp
  • src/EndcapCalorimeterWithInsertCutout_geo.cpp
  • src/ZeroDegreeCalorimeterSiPMonTile_geo.cpp
@veprbl veprbl added help wanted Extra attention is needed good first issue Good for newcomers labels Sep 26, 2023
@veprbl veprbl changed the title Ideally, you create the logical layer volume once and place it several times. The flow would be: Avoid creating repetitive logical volumes for sampling calorimeters Sep 26, 2023
@kkauder kkauder added enhancement New feature or request topic: simulation labels Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed topic: simulation
Projects
Development

No branches or pull requests

2 participants