Implement the new detector parameters #552

Chao1009 · 2023-10-09T04:56:57Z

Is your feature request related to a problem? Please describe.
The current simulation geometry implementation is inconsistent with the latest detector parameter table.
det: https://eic.jlab.org/Geometry/Detector/local/D/DetectorParameterTable-20230927.csv
sim: https://eic.github.io/epic/artifacts/DetectorParameterTable/epic_craterlake.csv

Describe the solution you'd like
Update the parameter table template and the compact files to make them as consistent as possible. (some mismatches are from geometry and some are from table generation)
Some of the updates may require changes in geometry plugins. These are supposed to be coordinated work with the corresponding DSCs.

Describe alternatives you've considered
No.

Additional context
Corresponding DSCs need to be informed and confirm the changes before merging PRs.

Chao1009 · 2023-10-09T04:57:42Z

EDIT: update the comparison for main branch on 2023/10/12

CENTRAL DETECTOR, Barrel EMCal, : 
                            det    sim                  template_var        stat
Length (cm)               470.0  635.0         {{EcalBarrel_length}}  Mismatched
Inner Radius (cm)          81.0   78.5           {{EcalBarrel_rmin}}  Mismatched
Outer Radius (cm)         116.0  140.0           {{EcalBarrel_rmax}}  Mismatched
Offset from Center (cm)  -38.75    NaN                         Empty     Missing
Physical Start (cm)     -273.75 -440.0  -{{EcalBarrelBackward_zmax}}  Mismatched
Physical End (cm)        196.25  195.0    {{EcalBarrelForward_zmax}}  Mismatched
 
CENTRAL DETECTOR, Barrel EMCal, Exterior Cover: 
                            det  sim template_var     stat
Length (cm)               460.0  NaN        Empty  Missing
Inner Radius (cm)         114.0  NaN        Empty  Missing
Outer Radius (cm)         116.0  NaN        Empty  Missing
Offset from Center (cm)  -38.75  NaN        Empty  Missing
Physical Start (cm)     -268.75  NaN        Empty  Missing
Physical End (cm)        191.25  NaN        Empty  Missing
 
CENTRAL DETECTOR, Barrel EMCal, HD Readout Electronics: 
                            det  sim template_var     stat
Length (cm)                15.0  NaN        Empty  Missing
Inner Radius (cm)          81.0  NaN        Empty  Missing
Outer Radius (cm)         116.0  NaN        Empty  Missing
Offset from Center (cm)  181.25  NaN        Empty  Missing
Physical Start (cm)      181.25  NaN        Empty  Missing
Physical End (cm)        196.25  NaN        Empty  Missing
 
CENTRAL DETECTOR, Barrel EMCal, Imaging Part: 
                            det  sim template_var     stat
Length (cm)               440.0  NaN        Empty  Missing
Inner Radius (cm)          81.0  NaN        Empty  Missing
Outer Radius (cm)          96.0  NaN        Empty  Missing
Offset from Center (cm)  -38.75  NaN        Empty  Missing
Physical Start (cm)     -258.75  NaN        Empty  Missing
Physical End (cm)        181.25  NaN        Empty  Missing
 
CENTRAL DETECTOR, Barrel EMCal, LD Readout Electronics: 
                            det  sim template_var     stat
Length (cm)                15.0  NaN        Empty  Missing
Inner Radius (cm)          81.0  NaN        Empty  Missing
Outer Radius (cm)         116.0  NaN        Empty  Missing
Offset from Center (cm) -258.75  NaN        Empty  Missing
Physical Start (cm)     -273.75  NaN        Empty  Missing
Physical End (cm)       -258.75  NaN        Empty  Missing
 
CENTRAL DETECTOR, Barrel EMCal, Sampling Part: 
                            det  sim template_var     stat
Length (cm)               440.0  NaN        Empty  Missing
Inner Radius (cm)          96.0  NaN        Empty  Missing
Outer Radius (cm)         114.0  NaN        Empty  Missing
Offset from Center (cm)  -38.75  NaN        Empty  Missing
Physical Start (cm)     -258.75  NaN        Empty  Missing
Physical End (cm)        181.25  NaN        Empty  Missing
 
CENTRAL DETECTOR, Barrel Flux Return, : 
                           det  sim template_var     stat
Length (cm)              632.0  NaN        Empty  Missing
Inner Radius (cm)        269.0  NaN        Empty  Missing
Outer Radius (cm)        324.0  NaN        Empty  Missing
Offset from Center (cm)    0.0  NaN        Empty  Missing
Physical Start (cm)     -316.0  NaN        Empty  Missing
Physical End (cm)        316.0  NaN        Empty  Missing
 
CENTRAL DETECTOR, Barrel Hadron Calorimeter, : 
                           det    sim                  template_var        stat
Length (cm)              570.0  635.6         {{HcalBarrel_length}}  Mismatched
Inner Radius (cm)        180.0  177.0           {{HcalBarrel_rmin}}  Mismatched
Outer Radius (cm)        267.0  270.0           {{HcalBarrel_rmax}}  Mismatched
Offset from Center (cm)    0.0    NaN                         Empty     Missing
Physical Start (cm)     -285.0 -316.0  -{{HcalBarrelBackward_zmax}}  Mismatched
Physical End (cm)        285.0  319.6    {{HcalBarrelForward_zmax}}  Mismatched
 
CENTRAL DETECTOR, Barrel Hadron Calorimeter, Central Section: 
                           det  sim template_var     stat
Length (cm)              300.0  NaN        Empty  Missing
Inner Radius (cm)        180.0  NaN        Empty  Missing
Outer Radius (cm)        267.0  NaN        Empty  Missing
Offset from Center (cm)  -35.0  NaN        Empty  Missing
Physical Start (cm)     -185.0  NaN        Empty  Missing
Physical End (cm)        115.0  NaN        Empty  Missing
 
CENTRAL DETECTOR, Barrel Hadron Calorimeter, HD Section: 
                           det  sim template_var     stat
Length (cm)              170.0  NaN        Empty  Missing
Inner Radius (cm)        194.0  NaN        Empty  Missing
Outer Radius (cm)        267.0  NaN        Empty  Missing
Offset from Center (cm)  200.0  NaN        Empty  Missing
Physical Start (cm)      115.0  NaN        Empty  Missing
Physical End (cm)        285.0  NaN        Empty  Missing
 
CENTRAL DETECTOR, Barrel Hadron Calorimeter, LD Section: 
                           det  sim template_var     stat
Length (cm)              100.0  NaN        Empty  Missing
Inner Radius (cm)        194.0  NaN        Empty  Missing
Outer Radius (cm)        267.0  NaN        Empty  Missing
Offset from Center (cm) -235.0  NaN        Empty  Missing
Physical Start (cm)     -285.0  NaN        Empty  Missing
Physical End (cm)       -185.0  NaN        Empty  Missing
 
CENTRAL DETECTOR, Barrel HD EMCal Support, : 
                             det  sim template_var     stat
Length (cm)                26.67  NaN        Empty  Missing
Inner Radius (cm)          115.8  NaN        Empty  Missing
Outer Radius (cm)          194.0  NaN        Empty  Missing
Offset from Center (cm)    200.0  NaN        Empty  Missing
Physical Start (cm)      186.665  NaN        Empty  Missing
Physical End (cm)        213.335  NaN        Empty  Missing
 
CENTRAL DETECTOR, Barrel HD EMCal Support, Exterior Plate: 
                             det  sim template_var     stat
Length (cm)                26.67  NaN        Empty  Missing
Inner Radius (cm)          185.4  NaN        Empty  Missing
Outer Radius (cm)          194.0  NaN        Empty  Missing
Offset from Center (cm)    200.0  NaN        Empty  Missing
Physical Start (cm)      186.665  NaN        Empty  Missing
Physical End (cm)        213.335  NaN        Empty  Missing
 
CENTRAL DETECTOR, Barrel HD EMCal Support, Support Ring: 
                            det  sim template_var     stat
Length (cm)               10.16  NaN        Empty  Missing
Inner Radius (cm)         115.8  NaN        Empty  Missing
Outer Radius (cm)         185.4  NaN        Empty  Missing
Offset from Center (cm)   200.0  NaN        Empty  Missing
Physical Start (cm)      194.92  NaN        Empty  Missing
Physical End (cm)        205.08  NaN        Empty  Missing
 
CENTRAL DETECTOR, Barrel LD EMCal Support, : 
                             det  sim template_var     stat
Length (cm)                26.67  NaN        Empty  Missing
Inner Radius (cm)          115.8  NaN        Empty  Missing
Outer Radius (cm)          194.0  NaN        Empty  Missing
Offset from Center (cm)  -222.25  NaN        Empty  Missing
Physical Start (cm)     -235.585  NaN        Empty  Missing
Physical End (cm)       -208.915  NaN        Empty  Missing
 
CENTRAL DETECTOR, Barrel LD EMCal Support, Exterior Plate: 
                             det  sim template_var     stat
Length (cm)                26.67  NaN        Empty  Missing
Inner Radius (cm)          185.4  NaN        Empty  Missing
Outer Radius (cm)          194.0  NaN        Empty  Missing
Offset from Center (cm)  -222.25  NaN        Empty  Missing
Physical Start (cm)     -235.585  NaN        Empty  Missing
Physical End (cm)       -208.915  NaN        Empty  Missing
 
CENTRAL DETECTOR, Barrel LD EMCal Support, Support Ring: 
                            det  sim template_var     stat
Length (cm)               10.16  NaN        Empty  Missing
Inner Radius (cm)         115.8  NaN        Empty  Missing
Outer Radius (cm)         185.4  NaN        Empty  Missing
Offset from Center (cm) -222.25  NaN        Empty  Missing
Physical Start (cm)     -227.33  NaN        Empty  Missing
Physical End (cm)       -217.17  NaN        Empty  Missing
 
CENTRAL DETECTOR, Barrel Time of Flight/Tracker, : 
                           det    sim          template_var        stat
Length (cm)              289.0  286.5  {{BarrelTOF_length}}  Mismatched
Inner Radius (cm)         56.0   63.0    {{BarrelTOF_rmin}}  Mismatched
Outer Radius (cm)         63.0   66.0    {{BarrelTOF_rmax}}  Mismatched
Offset from Center (cm)   27.0    NaN                 Empty     Missing
Physical Start (cm)     -117.5    NaN                 Empty     Missing
Physical End (cm)        171.5    NaN                 Empty     Missing
 
CENTRAL DETECTOR, Dual RICH, : 
                           det    sim                 template_var        stat
Length (cm)              120.0  120.0             {{DRICH_length}}     Correct
Inner Radius (cm)         14.0   8.49              {{DRICH_rmin0}}  Mismatched
Outer Radius (cm)        180.0  185.0              {{DRICH_rmax2}}  Mismatched
Offset from Center (cm)  320.0    NaN                        Empty     Missing
Physical Start (cm)      200.0  195.0               {{DRICH_zmin}}  Mismatched
Physical End (cm)        320.0  315.0  {{DRICH_zmin+DRICH_length}}  Mismatched
 
CENTRAL DETECTOR, Dual RICH, Aerogel Section: 
                             det   sim     template_var        stat
Length (cm)                 26.0   NaN            Empty     Missing
Inner Radius (cm)           14.0  8.49  {{DRICH_rmin0}}  Mismatched
Outer Radius (cm)        109.413   NaN            Empty     Missing
Offset from Center (cm)    200.0   NaN            Empty     Missing
Physical Start (cm)        200.0   NaN            Empty     Missing
Physical End (cm)          226.0   NaN            Empty     Missing
 
CENTRAL DETECTOR, Dual RICH, Detector Section: 
                           det   sim     template_var        stat
Length (cm)               94.0   NaN            Empty     Missing
Inner Radius (cm)         14.0  8.49  {{DRICH_rmin0}}  Mismatched
Outer Radius (cm)        180.0   NaN            Empty     Missing
Offset from Center (cm)  226.0   NaN            Empty     Missing
Physical Start (cm)      226.0   NaN            Empty     Missing
Physical End (cm)        320.0   NaN            Empty     Missing
 
CENTRAL DETECTOR, HD MPGD 1, : 
                           det      sim                                                 template_var        stat
Length (cm)                2.5      NaN                                                        Empty     Missing
Inner Radius (cm)        7.014    7.014                                   {{ForwardMPGDLayer1_rmin}}     Correct
Outer Radius (cm)         50.0     50.0                                   {{ForwardMPGDLayer1_rmax}}     Correct
Offset from Center (cm)  148.0      NaN                                                        Empty     Missing
Physical Start (cm)      148.0  147.639                                   {{ForwardMPGDLayer1_zmin}}  Mismatched
Physical End (cm)        150.5  148.361  {{ForwardMPGDLayer1_zmin+ForwardMPGDEndcapLayer_thickness}}  Mismatched
 
CENTRAL DETECTOR, HD MPGD 2, : 
                           det      sim                                                 template_var        stat
Length (cm)                2.5      NaN                                                        Empty     Missing
Inner Radius (cm)        7.014    7.014                                   {{ForwardMPGDLayer2_rmin}}     Correct
Outer Radius (cm)         50.0     50.0                                   {{ForwardMPGDLayer2_rmax}}     Correct
Offset from Center (cm)  161.0      NaN                                                        Empty     Missing
Physical Start (cm)      161.0  160.639                                   {{ForwardMPGDLayer2_zmin}}  Mismatched
Physical End (cm)        163.5  161.361  {{ForwardMPGDLayer2_zmin+ForwardMPGDEndcapLayer_thickness}}  Mismatched
 
CENTRAL DETECTOR, HD Time of Flight/Tracker, : 
                           det  sim template_var     stat
Length (cm)               15.0  NaN        Empty  Missing
Inner Radius (cm)          8.0  NaN        Empty  Missing
Outer Radius (cm)         60.0  NaN        Empty  Missing
Offset from Center (cm)  180.0  NaN        Empty  Missing
Physical Start (cm)      180.0  NaN        Empty  Missing
Physical End (cm)        195.0  NaN        Empty  Missing
 
CENTRAL DETECTOR, Inner Tracker (Micromegas), : 
                           det  sim template_var     stat
Length (cm)              265.0  NaN        Empty  Missing
Inner Radius (cm)        49.75  NaN        Empty  Missing
Outer Radius (cm)         51.0  NaN        Empty  Missing
Offset from Center (cm)   12.5  NaN        Empty  Missing
Physical Start (cm)     -120.0  NaN        Empty  Missing
Physical End (cm)        145.0  NaN        Empty  Missing
 
CENTRAL DETECTOR, Inner Tracker (Micromegas), Micromega 1: 
                           det  sim template_var     stat
Length (cm)               70.0  NaN        Empty  Missing
Inner Radius (cm)        49.75  NaN        Empty  Missing
Outer Radius (cm)         50.0  NaN        Empty  Missing
Offset from Center (cm)   78.0  NaN        Empty  Missing
Physical Start (cm)       43.0  NaN        Empty  Missing
Physical End (cm)        113.0  NaN        Empty  Missing
 
CENTRAL DETECTOR, Inner Tracker (Micromegas), Micromega 2: 
                           det  sim template_var     stat
Length (cm)               70.0  NaN        Empty  Missing
Inner Radius (cm)        50.75  NaN        Empty  Missing
Outer Radius (cm)         51.0  NaN        Empty  Missing
Offset from Center (cm)  110.0  NaN        Empty  Missing
Physical Start (cm)       75.0  NaN        Empty  Missing
Physical End (cm)        145.0  NaN        Empty  Missing
 
CENTRAL DETECTOR, Inner Tracker (Micromegas), Micromega 3: 
                           det  sim template_var     stat
Length (cm)               70.0  NaN        Empty  Missing
Inner Radius (cm)        50.75  NaN        Empty  Missing
Outer Radius (cm)         51.0  NaN        Empty  Missing
Offset from Center (cm)  -85.0  NaN        Empty  Missing
Physical Start (cm)     -120.0  NaN        Empty  Missing
Physical End (cm)        -50.0  NaN        Empty  Missing
 
CENTRAL DETECTOR, Inner Tracker (Micromegas), Micromega 4: 
                           det  sim template_var     stat
Length (cm)               70.0  NaN        Empty  Missing
Inner Radius (cm)        51.75  NaN        Empty  Missing
Outer Radius (cm)         52.0  NaN        Empty  Missing
Offset from Center (cm)    5.0  NaN        Empty  Missing
Physical Start (cm)      -30.0  NaN        Empty  Missing
Physical End (cm)         40.0  NaN        Empty  Missing
 
CENTRAL DETECTOR, Inner Tracker (Micromegas), Micromega 5: 
                           det  sim template_var     stat
Length (cm)               70.0  NaN        Empty  Missing
Inner Radius (cm)        52.75  NaN        Empty  Missing
Outer Radius (cm)         53.0  NaN        Empty  Missing
Offset from Center (cm)  -10.0  NaN        Empty  Missing
Physical Start (cm)      -45.0  NaN        Empty  Missing
Physical End (cm)         25.0  NaN        Empty  Missing
 
CENTRAL DETECTOR, Inner Tracker (Si Barrel), : 
                          det  sim template_var     stat
Length (cm)              80.0  NaN        Empty  Missing
Inner Radius (cm)         3.6  NaN        Empty  Missing
Outer Radius (cm)        45.5  NaN        Empty  Missing
Offset from Center (cm)   0.0  NaN        Empty  Missing
Physical Start (cm)     -40.0  NaN        Empty  Missing
Physical End (cm)        40.0  NaN        Empty  Missing
 
CENTRAL DETECTOR, Inner Tracker (Si Barrel), Si Layer 1: 
                          det   sim                        template_var        stat
Length (cm)              27.0   NaN                               Empty     Missing
Inner Radius (cm)         3.6   3.5         {{VertexBarrelLayer1_rmin}}  Mismatched
Outer Radius (cm)         4.1   3.7         {{VertexBarrelLayer1_rmax}}  Mismatched
Offset from Center (cm)   0.0   NaN                               Empty     Missing
Physical Start (cm)     -13.5 -24.0  -{{VertexBarrelEnvelope_length/2}}  Mismatched
Physical End (cm)        13.5  24.0   {{VertexBarrelEnvelope_length/2}}  Mismatched
 
CENTRAL DETECTOR, Inner Tracker (Si Barrel), Si Layer 2: 
                          det   sim                        template_var        stat
Length (cm)              27.0   NaN                               Empty     Missing
Inner Radius (cm)         4.8   4.7         {{VertexBarrelLayer2_rmin}}  Mismatched
Outer Radius (cm)         5.3   4.9         {{VertexBarrelLayer2_rmax}}  Mismatched
Offset from Center (cm)   0.0   NaN                               Empty     Missing
Physical Start (cm)     -13.5 -24.0  -{{VertexBarrelEnvelope_length/2}}  Mismatched
Physical End (cm)        13.5  24.0   {{VertexBarrelEnvelope_length/2}}  Mismatched
 
CENTRAL DETECTOR, Inner Tracker (Si Barrel), Si Layer 3: 
                          det   sim                        template_var        stat
Length (cm)              27.0   NaN                               Empty     Missing
Inner Radius (cm)         8.0  11.9         {{VertexBarrelLayer3_rmin}}  Mismatched
Outer Radius (cm)         8.5  12.1         {{VertexBarrelLayer3_rmax}}  Mismatched
Offset from Center (cm)   0.0   NaN                               Empty     Missing
Physical Start (cm)     -13.5 -24.0  -{{VertexBarrelEnvelope_length/2}}  Mismatched
Physical End (cm)        13.5  24.0   {{VertexBarrelEnvelope_length/2}}  Mismatched
 
CENTRAL DETECTOR, Inner Tracker (Si Barrel), Si Layer 4: 
                          det   sim                  template_var        stat
Length (cm)              54.0   NaN                         Empty     Missing
Inner Radius (cm)        27.0  27.1       {{SiBarrelLayer1_rmin}}  Mismatched
Outer Radius (cm)        27.5  30.1       {{SiBarrelLayer1_rmax}}  Mismatched
Offset from Center (cm)   0.0   NaN                         Empty     Missing
Physical Start (cm)     -27.0 -26.1  -{{SiBarrelLayer1_length/2}}  Mismatched
Physical End (cm)        27.0  26.1   {{SiBarrelLayer1_length/2}}  Mismatched
 
CENTRAL DETECTOR, Inner Tracker (Si Barrel), Si Layer 5: 
                          det   sim                  template_var        stat
Length (cm)              80.0   NaN                         Empty     Missing
Inner Radius (cm)        45.0  43.0       {{SiBarrelLayer2_rmin}}  Mismatched
Outer Radius (cm)        45.5  46.0       {{SiBarrelLayer2_rmax}}  Mismatched
Offset from Center (cm)   0.0   NaN                         Empty     Missing
Physical Start (cm)     -40.0 -26.1  -{{SiBarrelLayer1_length/2}}  Mismatched
Physical End (cm)        40.0  26.1   {{SiBarrelLayer1_length/2}}  Mismatched
 
CENTRAL DETECTOR, Inner Tracker (Si Disks), : 
                            det  sim template_var     stat
Length (cm)               242.5  NaN        Empty  Missing
Inner Radius (cm)         3.676  NaN        Empty  Missing
Outer Radius (cm)          43.0  NaN        Empty  Missing
Offset from Center (cm)    15.0  NaN        Empty  Missing
Physical Start (cm)     -106.25  NaN        Empty  Missing
Physical End (cm)        136.25  NaN        Empty  Missing
 
CENTRAL DETECTOR, Inner Tracker (Si Disks), HD Disk 1: 
                           det     sim                                                       template_var        stat
Length (cm)                2.5     NaN                                                              Empty     Missing
Inner Radius (cm)        3.676   3.676                                 {{InnerTrackerEndcapPLayer1_rmin}}     Correct
Outer Radius (cm)         23.0    24.0                                 {{InnerTrackerEndcapPLayer1_rmax}}  Mismatched
Offset from Center (cm)   25.0     NaN                                                              Empty     Missing
Physical Start (cm)      23.75  24.984                                 {{InnerTrackerEndcapPLayer1_zmin}}  Mismatched
Physical End (cm)        26.25  25.015  {{InnerTrackerEndcapPLayer1_zmin+SiTrackerEndcapLayer_thickness}}  Mismatched
 
CENTRAL DETECTOR, Inner Tracker (Si Disks), HD Disk 2: 
                           det     sim                                                  template_var        stat
Length (cm)                2.5     NaN                                                         Empty     Missing
Inner Radius (cm)        3.676   3.676                                 {{TrackerEndcapPLayer1_rmin}}     Correct
Outer Radius (cm)         43.0    41.5                                 {{TrackerEndcapPLayer1_rmax}}  Mismatched
Offset from Center (cm)   45.0     NaN                                                         Empty     Missing
Physical Start (cm)      43.75  44.984                                 {{TrackerEndcapPLayer1_zmin}}  Mismatched
Physical End (cm)        46.25  45.015  {{TrackerEndcapPLayer1_zmin+SiTrackerEndcapLayer_thickness}}  Mismatched
 
CENTRAL DETECTOR, Inner Tracker (Si Disks), HD Disk 3: 
                           det     sim                                                  template_var        stat
Length (cm)                2.5     NaN                                                         Empty     Missing
Inner Radius (cm)        3.842   3.846                                 {{TrackerEndcapPLayer2_rmin}}  Mismatched
Outer Radius (cm)         43.0   42.14                                 {{TrackerEndcapPLayer2_rmax}}  Mismatched
Offset from Center (cm)   70.0     NaN                                                         Empty     Missing
Physical Start (cm)      68.75  69.984                                 {{TrackerEndcapPLayer2_zmin}}  Mismatched
Physical End (cm)        71.25  70.015  {{TrackerEndcapPLayer2_zmin+SiTrackerEndcapLayer_thickness}}  Mismatched
 
CENTRAL DETECTOR, Inner Tracker (Si Disks), HD Disk 4: 
                            det      sim                                                  template_var        stat
Length (cm)                 2.5      NaN                                                         Empty     Missing
Inner Radius (cm)         5.443    5.343                                 {{TrackerEndcapPLayer3_rmin}}  Mismatched
Outer Radius (cm)          43.0    42.14                                 {{TrackerEndcapPLayer3_rmax}}  Mismatched
Offset from Center (cm)   100.0      NaN                                                         Empty     Missing
Physical Start (cm)       98.75   99.984                                 {{TrackerEndcapPLayer3_zmin}}  Mismatched
Physical End (cm)        101.25  100.015  {{TrackerEndcapPLayer3_zmin+SiTrackerEndcapLayer_thickness}}  Mismatched
 
CENTRAL DETECTOR, Inner Tracker (Si Disks), HD Disk 5: 
                            det      sim                                                  template_var        stat
Length (cm)                 2.5      NaN                                                         Empty     Missing
Inner Radius (cm)         7.014    7.014                                 {{TrackerEndcapPLayer4_rmin}}     Correct
Outer Radius (cm)          43.0    42.14                                 {{TrackerEndcapPLayer4_rmax}}  Mismatched
Offset from Center (cm)   135.0      NaN                                                         Empty     Missing
Physical Start (cm)      133.75  134.984                                 {{TrackerEndcapPLayer4_zmin}}  Mismatched
Physical End (cm)        136.25  135.015  {{TrackerEndcapPLayer4_zmin+SiTrackerEndcapLayer_thickness}}  Mismatched
 
CENTRAL DETECTOR, Inner Tracker (Si Disks), LD Disk 1: 
                           det     sim                                                       template_var        stat
Length (cm)                2.5     NaN                                                              Empty     Missing
Inner Radius (cm)        3.676   3.676                                 {{InnerTrackerEndcapNLayer1_rmin}}     Correct
Outer Radius (cm)         23.0    24.0                                 {{InnerTrackerEndcapNLayer1_rmax}}  Mismatched
Offset from Center (cm)  -25.0     NaN                                                              Empty     Missing
Physical Start (cm)     -26.25  24.984                                 {{InnerTrackerEndcapNLayer1_zmin}}  Mismatched
Physical End (cm)       -23.75  25.015  {{InnerTrackerEndcapNLayer1_zmin+SiTrackerEndcapLayer_thickness}}  Mismatched
 
CENTRAL DETECTOR, Inner Tracker (Si Disks), LD Disk 2: 
                           det     sim                                                   template_var        stat
Length (cm)                2.5     NaN                                                          Empty     Missing
Inner Radius (cm)        3.676   3.676                                  {{TrackerEndcapNLayer1_rmin}}     Correct
Outer Radius (cm)         43.0    41.5                                  {{TrackerEndcapNLayer1_rmax}}  Mismatched
Offset from Center (cm)  -45.0     NaN                                                          Empty     Missing
Physical Start (cm)     -46.25 -45.015  -{{TrackerEndcapNLayer1_zmin+SiTrackerEndcapLayer_thickness}}  Mismatched
Physical End (cm)       -43.75 -44.984                                 -{{TrackerEndcapNLayer1_zmin}}  Mismatched
 
CENTRAL DETECTOR, Inner Tracker (Si Disks), LD Disk 3: 
                           det     sim                                                   template_var        stat
Length (cm)                2.5     NaN                                                          Empty     Missing
Inner Radius (cm)        3.676   3.676                                  {{TrackerEndcapNLayer2_rmin}}     Correct
Outer Radius (cm)         43.0   42.14                                  {{TrackerEndcapNLayer2_rmax}}  Mismatched
Offset from Center (cm)  -65.0     NaN                                                          Empty     Missing
Physical Start (cm)     -66.25 -65.015  -{{TrackerEndcapNLayer2_zmin+SiTrackerEndcapLayer_thickness}}  Mismatched
Physical End (cm)       -63.75 -64.984                                 -{{TrackerEndcapNLayer2_zmin}}  Mismatched
 
CENTRAL DETECTOR, Inner Tracker (Si Disks), LD Disk 4: 
                             det     sim                                                   template_var        stat
Length (cm)                  2.5     NaN                                                          Empty     Missing
Inner Radius (cm)        4.00614   4.006                                  {{TrackerEndcapNLayer3_rmin}}  Mismatched
Outer Radius (cm)           43.0   42.14                                  {{TrackerEndcapNLayer3_rmax}}  Mismatched
Offset from Center (cm)    -85.0     NaN                                                          Empty     Missing
Physical Start (cm)       -86.25 -85.015  -{{TrackerEndcapNLayer3_zmin+SiTrackerEndcapLayer_thickness}}  Mismatched
Physical End (cm)         -83.75 -84.984                                 -{{TrackerEndcapNLayer3_zmin}}  Mismatched
 
CENTRAL DETECTOR, Inner Tracker (Si Disks), LD Disk 5: 
                             det      sim                                                   template_var        stat
Length (cm)                  2.5      NaN                                                          Empty     Missing
Inner Radius (cm)        4.63529    4.635                                  {{TrackerEndcapNLayer4_rmin}}  Mismatched
Outer Radius (cm)           43.0    42.14                                  {{TrackerEndcapNLayer4_rmax}}  Mismatched
Offset from Center (cm)   -105.0      NaN                                                          Empty     Missing
Physical Start (cm)      -106.25 -105.015  -{{TrackerEndcapNLayer4_zmin+SiTrackerEndcapLayer_thickness}}  Mismatched
Physical End (cm)        -103.75 -104.984                                 -{{TrackerEndcapNLayer4_zmin}}  Mismatched
 
CENTRAL DETECTOR, Integrated DIRC/MPGD Detector, : 
                           det    sim            template_var        stat
Length (cm)              488.0    NaN                   Empty     Missing
Inner Radius (cm)         72.5   70.0           {{DIRC_rmin}}  Mismatched
Outer Radius (cm)        108.0   73.0           {{DIRC_rmax}}  Mismatched
Offset from Center (cm) -273.0    NaN                   Empty     Missing
Physical Start (cm)     -303.0 -287.0  -{{DIRCBackward_zmax}}  Mismatched
Physical End (cm)        185.0  185.0    {{DIRCForward_zmax}}     Correct
 
CENTRAL DETECTOR, Integrated DIRC/MPGD Detector, Dirc Bar/MPGD  Support: 
                           det  sim template_var     stat
Length (cm)              458.0  NaN        Empty  Missing
Inner Radius (cm)         73.3  NaN        Empty  Missing
Outer Radius (cm)         81.0  NaN        Empty  Missing
Offset from Center (cm) -273.0  NaN        Empty  Missing
Physical Start (cm)     -273.0  NaN        Empty  Missing
Physical End (cm)        185.0  NaN        Empty  Missing
 
CENTRAL DETECTOR, Integrated DIRC/MPGD Detector, DIRC Bar Box: 
                           det      sim        template_var        stat
Length (cm)              458.0  110.145  {{DIRCBar_length}}  Mismatched
Inner Radius (cm)         75.5      NaN               Empty     Missing
Outer Radius (cm)         78.6      NaN               Empty     Missing
Offset from Center (cm) -273.0      NaN               Empty     Missing
Physical Start (cm)     -273.0      NaN               Empty     Missing
Physical End (cm)        185.0      NaN               Empty     Missing
 
CENTRAL DETECTOR, Integrated DIRC/MPGD Detector, DIRC Readout Support: 
                           det   sim            template_var     stat
Length (cm)               30.0  30.0  {{DIRCReadout_length}}  Correct
Inner Radius (cm)         73.3   NaN                   Empty  Missing
Outer Radius (cm)        108.0   NaN                   Empty  Missing
Offset from Center (cm) -273.0   NaN                   Empty  Missing
Physical Start (cm)     -303.0   NaN                   Empty  Missing
Physical End (cm)       -273.0   NaN                   Empty  Missing
 
CENTRAL DETECTOR, Integrated DIRC/MPGD Detector, Inner MPGD: 
                           det  sim template_var     stat
Length (cm)              339.0  NaN        Empty  Missing
Inner Radius (cm)         72.5  NaN        Empty  Missing
Outer Radius (cm)         75.0  NaN        Empty  Missing
Offset from Center (cm)    5.0  NaN        Empty  Missing
Physical Start (cm)     -164.5  NaN        Empty  Missing
Physical End (cm)        174.5  NaN        Empty  Missing
 
CENTRAL DETECTOR, LD EMCal, : 
                           det    sim            template_var     stat
Length (cm)               60.0   60.0  {{EcalEndcapN_length}}  Correct
Inner Radius (cm)          9.0    9.0    {{EcalEndcapN_rmin}}  Correct
Outer Radius (cm)         63.0   63.0    {{EcalEndcapN_rmax}}  Correct
Offset from Center (cm) -175.0    NaN                   Empty  Missing
Physical Start (cm)     -235.0 -235.0   -{{EcalEndcapN_zmax}}  Correct
Physical End (cm)       -175.0 -175.0   -{{EcalEndcapN_zmin}}  Correct
 
CENTRAL DETECTOR, LD MPGD 1, : 
                           det    sim               template_var        stat
Length (cm)                2.5    NaN                      Empty     Missing
Inner Radius (cm)        4.635  4.653  {{BackwardMPGDMod1_rmin}}  Mismatched
Outer Radius (cm)         50.0   50.0  {{BackwardMPGDMod1_rmax}}     Correct
Offset from Center (cm) -110.0    NaN                      Empty     Missing
Physical Start (cm)     -112.5 -110.0     -{{BackwardMPGD_zmin}}  Mismatched
Physical End (cm)       -110.0    NaN                      Empty     Missing
 
CENTRAL DETECTOR, LD MPGD 2, : 
                           det    sim                                   template_var        stat
Length (cm)                2.5    NaN                                          Empty     Missing
Inner Radius (cm)        4.635  4.635                      {{BackwardMPGDMod2_rmin}}     Correct
Outer Radius (cm)         50.0   50.0                      {{BackwardMPGDMod2_rmax}}     Correct
Offset from Center (cm) -120.0    NaN                                          Empty     Missing
Physical Start (cm)     -122.5 -120.0  -{{BackwardMPGD_zmin+BackwardMPGDMod_offset}}  Mismatched
Physical End (cm)       -120.0    NaN                                          Empty     Missing
 
CENTRAL DETECTOR, Proximity Focusing RICH, : 
                           det    sim                   template_var        stat
Length (cm)               45.0   49.1              {{PFRICH_length}}  Mismatched
Inner Radius (cm)          8.0  4.756               {{PFRICH_rmin0}}  Mismatched
Outer Radius (cm)         63.0   63.0                {{PFRICH_rmax}}     Correct
Offset from Center (cm) -146.0    NaN                          Empty     Missing
Physical Start (cm)     -168.5 -123.6                {{PFRICH_zmin}}  Mismatched
Physical End (cm)       -123.5 -172.7  {{PFRICH_zmin-PFRICH_length}}  Mismatched
 
CENTRAL DETECTOR, Service Gap, : 
                           det    sim                                            template_var        stat
Length (cm)              124.0    NaN                                                   Empty     Missing
Inner Radius (cm)          NaN    NaN                                                   Empty     Missing
Outer Radius (cm)          NaN    NaN                                                   Empty     Missing
Offset from Center (cm) -316.0    NaN                                                   Empty     Missing
Physical Start (cm)     -440.0 -564.0  -{{BackwardServiceGap_zmax+BackwardServiceGap_length}}  Mismatched
Physical End (cm)       -316.0 -440.0                            -{{BackwardServiceGap_zmax}}  Mismatched
 
CENTRAL DETECTOR, Solenoid Magnet, : 
                           det    sim                template_var     stat
Length (cm)              384.0  384.0         {{Solenoid_length}}  Correct
Inner Radius (cm)        142.0  142.0           {{Solenoid_rmin}}  Correct
Outer Radius (cm)        177.0  177.0           {{Solenoid_rmax}}  Correct
Offset from Center (cm)  -10.0    NaN                       Empty  Missing
Physical Start (cm)     -202.0 -202.0  -{{SolenoidBackward_zmax}}  Correct
Physical End (cm)        182.0  182.0    {{SolenoidForward_zmax}}  Correct
 
HADRON DIRECTION END CAP, Electromagnetic Calorimeter, : 
                           det    sim            template_var        stat
Length (cm)               30.0   30.0  {{EcalEndcapP_length}}     Correct
Inner Radius (cm)         14.0   20.0    {{EcalEndcapP_rmin}}  Mismatched
Outer Radius (cm)        195.0  174.0    {{EcalEndcapP_rmax}}  Mismatched
Offset from Center (cm)  329.6    NaN                   Empty     Missing
Physical Start (cm)      329.6  333.2    {{EcalEndcapP_zmin}}  Mismatched
Physical End (cm)        359.6  363.2    {{EcalEndcapP_zmax}}  Mismatched
 
HADRON DIRECTION END CAP, Hadron Calorimeter, : 
                           det    sim       template_var        stat
Length (cm)              140.0  140.0  {{LFHCAL_length}}     Correct
Inner Radius (cm)         17.5    0.0                  0  Mismatched
Outer Radius (cm)        267.0  270.0    {{LFHCAL_rmax}}  Mismatched
Offset from Center (cm)  359.6    NaN              Empty     Missing
Physical Start (cm)      359.6  363.2    {{LFHCAL_zmin}}  Mismatched
Physical End (cm)        499.6  503.2    {{LFHCAL_zmax}}  Mismatched
 
HADRON DIRECTION END CAP, HD Flux Return (Collar), : 
                           det  sim template_var     stat
Length (cm)              170.0  NaN        Empty  Missing
Inner Radius (cm)        269.0  NaN        Empty  Missing
Outer Radius (cm)        324.0  NaN        Empty  Missing
Offset from Center (cm)  414.6  NaN        Empty  Missing
Physical Start (cm)      329.6  NaN        Empty  Missing
Physical End (cm)        499.6  NaN        Empty  Missing
 
HADRON DIRECTION END CAP, HD Flux Return (Oculus), : 
                           det  sim template_var     stat
Length (cm)               22.2  NaN        Empty  Missing
Inner Radius (cm)        195.0  NaN        Empty  Missing
Outer Radius (cm)        267.0  NaN        Empty  Missing
Offset from Center (cm)  340.7  NaN        Empty  Missing
Physical Start (cm)      329.6  NaN        Empty  Missing
Physical End (cm)        351.8  NaN        Empty  Missing
 
HADRON DIRECTION END CAP, Service Gap, : 
                           det    sim                  template_var        stat
Length (cm)               13.6   13.6  {{ForwardServiceGap_length}}     Correct
Inner Radius (cm)          NaN    NaN                         Empty     Missing
Outer Radius (cm)          NaN    NaN                         Empty     Missing
Offset from Center (cm)  316.0    NaN                         Empty     Missing
Physical Start (cm)      316.0  319.6    {{ForwardServiceGap_zmin}}  Mismatched
Physical End (cm)        329.6  333.2    {{ForwardServiceGap_zmax}}  Mismatched
 
LEPTON DIRECTION ENDCAP, Backward HCal, : 
                           det     sim                              template_var        stat
Length (cm)               45.0     NaN                                     Empty     Missing
Inner Radius (cm)         12.4  14.353                      {{HcalEndcapN_rmin}}  Mismatched
Outer Radius (cm)        267.0   270.0                      {{HcalEndcapN_rmax}}  Mismatched
Offset from Center (cm) -395.0     NaN                                     Empty     Missing
Physical Start (cm)     -440.0  -485.0  -{{HcalEndcapN_zmin+HcalEndcapN_length}}  Mismatched
Physical End (cm)       -395.0  -440.0                     -{{HcalEndcapN_zmin}}  Mismatched
 
LEPTON DIRECTION ENDCAP, LD Flux Return (Collar), : 
                           det  sim template_var     stat
Length (cm)              120.4  NaN        Empty  Missing
Inner Radius (cm)        269.0  NaN        Empty  Missing
Outer Radius (cm)        324.0  NaN        Empty  Missing
Offset from Center (cm) -391.2  NaN        Empty  Missing
Physical Start (cm)     -451.4  NaN        Empty  Missing
Physical End (cm)       -331.0  NaN        Empty  Missing
 
LEPTON DIRECTION ENDCAP, LD Flux Return (Exterior), : 
                           det  sim template_var     stat
Length (cm)               10.0  NaN        Empty  Missing
Inner Radius (cm)         12.4  NaN        Empty  Missing
Outer Radius (cm)        267.0  NaN        Empty  Missing
Offset from Center (cm) -445.0  NaN        Empty  Missing
Physical Start (cm)     -450.0  NaN        Empty  Missing
Physical End (cm)       -440.0  NaN        Empty  Missing
 
LEPTON DIRECTION ENDCAP, LD Flux Return (Oculus), : 
                            det  sim template_var     stat
Length (cm)                28.5  NaN        Empty  Missing
Inner Radius (cm)         213.6  NaN        Empty  Missing
Outer Radius (cm)         267.0  NaN        Empty  Missing
Offset from Center (cm) -345.25  NaN        Empty  Missing
Physical Start (cm)      -359.5  NaN        Empty  Missing
Physical End (cm)        -331.0  NaN        Empty  Missing

wdconinc · 2023-10-09T15:28:21Z

        "Physical Start (cm)": {
            "det": -273.75,
            "sim": 195.0,
            "template_var": "{{EcalBarrelForward_zmax}}"
        },
        "Physical End (cm)": {
            "det": 196.25,
            "sim": -330.0,
            "template_var": "-{{EcalBarrelBackward_zmax}}"
        }

This seems to be a bug in the comparison script (in addition to a geometry mismatch). The physical start should not be EcalBarrelForward_zmax and vice versa.

Edit: it affects multiple detectors.

Chao1009 · 2023-10-09T15:36:59Z

Yes, it seems an issue in the template.
Edit: PR #553 will fix this.

### Briefly, what does this PR introduce? Update the template for generating a detector parameter table from simulation constants. The new template will be created based on the latest detector parameter table. (https://eic.jlab.org/Geometry/Detector/local/D/DetectorParameterTable-20230927.csv) It only focuses on the comparable columns, so some columns such as "comments" will be dropped. This PR partially resolves #552 ### What kind of change does this PR introduce? - [ ] Bug fix (issue #__) - [ ] New feature (issue #__) - [ ] Documentation update - [x] Other: __ ### Please check if this PR fulfills the following: - [ ] Tests for the changes have been added - [ ] Documentation has been added / updated - [x] Changes have been communicated to collaborators ### Does this PR introduce breaking changes? What changes might users need to make to their code? No ### Does this PR change default behavior? No --------- Co-authored-by: Chao Peng <cpeng@anl.gov> Co-authored-by: Wouter Deconinck <wdconinc@gmail.com>

### Briefly, what does this PR introduce? This PR related to the issue #552, and implements small changes in the Barrel ECal geometry to make it more realistic. The following changes has been implemented: - SciFi/Pb z_min and z_max (and accordingly the full length) has been implemented according to https://eic.jlab.org/Geometry/Detector/Detector-20231031150001.html. - The total depth (envelope) of the calorimeter has been increased to 38 cm (from fixed 35 cm). 38 cm envelope is the correct one and fits both the SciFi and the 3 cm back Al plate. - ~~In every AstroPix stave a carbon fiber slice has been added to mimic a bit better the material of the staves~~ ### What kind of change does this PR introduce? - [ ] Bug fix (issue #__) - [x] New feature (issue #552) - [ ] Documentation update - [ ] Other: __ ### Please check if this PR fulfills the following: - [ ] Tests for the changes have been added - [ ] Documentation has been added / updated - [x] Changes have been communicated to collaborators ### Does this PR introduce breaking changes? What changes might users need to make to their code? No ### Does this PR change default behavior? Calorimeter (SciFi/Pb matrix) length, offset, and z_min z_max are in agreement with the geometry database: Output of `npdet_info dump $DETECTOR_PATH/epic_craterlake.xml | grep EcalBarrel` ``` EcalBarrel_AvailThickness = 35.000 = EcalBarrelRegion_thickness - EcalBarrel_Support_thickness EcalBarrel_Calorimeter_length = 440.000 = EcalBarrel_Calorimeter_zmax + EcalBarrel_Calorimeter_zmin EcalBarrel_Calorimeter_offset = -38.750 = (EcalBarrel_Calorimeter_zmax - EcalBarrel_Calorimeter_zmin)/2.0 EcalBarrel_Calorimeter_zmax = 181.250 = min(181.25*cm, EcalBarrelForward_zmax) EcalBarrel_Calorimeter_zmin = 258.750 = min(258.75*cm, EcalBarrelBackward_zmax) ``` Now calorimeter has proper depth (together with back plate) ![SciFi part of the Calo. 12th layer has now proper width.](https://github.com/eic/epic/assets/33816222/70384133-39c5-4fb6-a19c-c5c5fbc1093b) ![Zoom on AstroPix part of the Calo](https://github.com/eic/epic/assets/33816222/f11b6e6d-8a06-430b-93f0-b3ff8c5273e4) Not included in this PR because of the problem with overlaps Below you can see the Carbon Fiber slice added to each stave. ![AstroPix part of the sector](https://github.com/eic/epic/assets/33816222/d3edbe40-14eb-46de-9908-454f46d5d30d) ![Zoom on one layer with modules](https://github.com/eic/epic/assets/33816222/a127bc45-79ca-479f-887f-a325e1a263b9) --------- Co-authored-by: Maria <zurek@anl.gov>

Chao1009 added the help wanted Extra attention is needed label Oct 9, 2023

Chao1009 mentioned this issue Oct 9, 2023

Add a script to compare detector parameter tables #551

Merged

7 tasks

This was referenced Oct 9, 2023

Update the template for detector parameter table #553

Merged

Comparison with updated DetectorParameterTable #539

Closed

Chao1009 added this to the Update Compact Files According to the 2023.09 Detector Parameters milestone Oct 10, 2023

Chao1009 closed this as completed in #553 Oct 12, 2023

kkauder added topic: geometry topic: simulation labels Oct 17, 2023

mariakzurek mentioned this issue Dec 4, 2023

Adjust Barrel ECal geometry according to the geometry database #606

Merged

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement the new detector parameters #552

Implement the new detector parameters #552

Chao1009 commented Oct 9, 2023 •

edited

Chao1009 commented Oct 9, 2023 •

edited

wdconinc commented Oct 9, 2023 •

edited

Chao1009 commented Oct 9, 2023 •

edited

Implement the new detector parameters #552

Implement the new detector parameters #552

Comments

Chao1009 commented Oct 9, 2023 • edited

Chao1009 commented Oct 9, 2023 • edited

wdconinc commented Oct 9, 2023 • edited

Chao1009 commented Oct 9, 2023 • edited

Chao1009 commented Oct 9, 2023 •

edited

Chao1009 commented Oct 9, 2023 •

edited

wdconinc commented Oct 9, 2023 •

edited

Chao1009 commented Oct 9, 2023 •

edited