-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the template for detector parameter table #553
Conversation
Edit: build the template based on 2023/09 table
|
### Briefly, what does this PR introduce? And we start to address the mismatches in #553. This one should actually be harmless. ### What kind of change does this PR introduce? - [x] Bug fix (issue #__) - [ ] New feature (issue #__) - [ ] Documentation update - [ ] Other: __ ### Please check if this PR fulfills the following: - [ ] Tests for the changes have been added - [ ] Documentation has been added / updated - [ ] Changes have been communicated to collaborators ### Does this PR introduce breaking changes? What changes might users need to make to their code? No. ### Does this PR change default behavior? No.
### Briefly, what does this PR introduce? And we start to address the mismatches in #553. This one should be mostly isolate from other parts. ### What kind of change does this PR introduce? - [x] Bug fix (issue: BackwardServiceGap_length is larger) - [ ] New feature (issue #__) - [ ] Documentation update - [ ] Other: __ ### Please check if this PR fulfills the following: - [ ] Tests for the changes have been added - [ ] Documentation has been added / updated - [x] Changes have been communicated to collaborators @lkosarz ### Does this PR introduce breaking changes? What changes might users need to make to their code? No. ### Does this PR change default behavior? No.
### Briefly, what does this PR introduce? And we start to address the mismatches in #553. This one should be fairly harmless. ### What kind of change does this PR introduce? - [x] Bug fix (issue: EcalEndcapN_zmin := 175cm, shift backwards by 1 cm) - [ ] New feature (issue #__) - [ ] Documentation update - [ ] Other: __ ### Please check if this PR fulfills the following: - [ ] Tests for the changes have been added - [ ] Documentation has been added / updated - [x] Changes have been communicated to collaborators @johnny8266 ### Does this PR introduce breaking changes? What changes might users need to make to their code? No. ### Does this PR change default behavior? No.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me for merging now.
Or we can wait and I can add the inner tracker r variables. I went through those today. Could also wait until a next pr and keep things moving. Your call.
I think we can wait for the inner tracker updates. There is no urgent need to merge this. |
d26a86d
to
e25474d
Compare
Yeah, but that's how you end up with eternal pull requests that just keep running parallel. My thinking is usually by asking myself the question "is there a clear milestone to call the PR done for which I could right now implement the commits if I only had the time," versus "is this something that could continue to be tweaked for a long time while asymptotically reaching perfection"? If it's the former, ok to wait with merge. If it's the latter, I try to do merges as I go along. |
This has to be
But we will update the information (the smaller comparison table) in those issues of "Detector Parameters Update" after merging this PR and fixing some obvious issues (e.g., #559). So the inclusion of the tracker parameters is good for this purpose. |
Briefly, what does this PR introduce?
Update the template for generating a detector parameter table from simulation constants.
The new template will be created based on the latest detector parameter table. (https://eic.jlab.org/Geometry/Detector/local/D/DetectorParameterTable-20230927.csv)
It only focuses on the comparable columns, so some columns such as "comments" will be dropped.
This PR partially resolves #552
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No
Does this PR change default behavior?
No