Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the template for detector parameter table #553

Merged
merged 9 commits into from
Oct 12, 2023

Conversation

Chao1009
Copy link
Contributor

@Chao1009 Chao1009 commented Oct 9, 2023

Briefly, what does this PR introduce?

Update the template for generating a detector parameter table from simulation constants.
The new template will be created based on the latest detector parameter table. (https://eic.jlab.org/Geometry/Detector/local/D/DetectorParameterTable-20230927.csv)
It only focuses on the comparable columns, so some columns such as "comments" will be dropped.
This PR partially resolves #552

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No

Does this PR change default behavior?

No

@Chao1009
Copy link
Contributor Author

Chao1009 commented Oct 9, 2023

Edit: build the template based on 2023/09 table
Now every row matches but most of them are just place holder (no simulation variable implemented)


    "stats": {
        "checked_columns": [
            "Length (cm)",
            "Inner Radius (cm)",
            "Outer Radius (cm)",
            "Offset from Center (cm)",
            "Physical Start (cm)",
            "Physical End (cm)"
        ],
        "table_components": {
            "detector": {
                "total": 67,
                "matched": 67,
                "missing": 0
            },
            "simulation": {
                "total": 67,
                "matched": 67,
                "missing": 0
            }
        },
        "component_values": {
            "checked_components": 67,
            "checked_values": 402,
            "mismatched": 27,
            "missing": 359,
            "correct": 16
        }
    },

@github-actions github-actions bot added the topic: infrastructure Regarding build system, CI, CD label Oct 9, 2023
@Chao1009 Chao1009 self-assigned this Oct 9, 2023
github-merge-queue bot pushed a commit that referenced this pull request Oct 11, 2023
### Briefly, what does this PR introduce?
And we start to address the mismatches in #553. This one should actually
be harmless.

### What kind of change does this PR introduce?
- [x] Bug fix (issue #__)
- [ ] New feature (issue #__)
- [ ] Documentation update
- [ ] Other: __

### Please check if this PR fulfills the following:
- [ ] Tests for the changes have been added
- [ ] Documentation has been added / updated
- [ ] Changes have been communicated to collaborators

### Does this PR introduce breaking changes? What changes might users
need to make to their code?
No.

### Does this PR change default behavior?
No.
github-merge-queue bot pushed a commit that referenced this pull request Oct 11, 2023
### Briefly, what does this PR introduce?
And we start to address the mismatches in
#553. This one should be mostly isolate
from other parts.

### What kind of change does this PR introduce?
- [x] Bug fix (issue: BackwardServiceGap_length is larger)
- [ ] New feature (issue #__)
- [ ] Documentation update
- [ ] Other: __

### Please check if this PR fulfills the following:
- [ ] Tests for the changes have been added
- [ ] Documentation has been added / updated
- [x] Changes have been communicated to collaborators @lkosarz 

### Does this PR introduce breaking changes? What changes might users
need to make to their code?
No.

### Does this PR change default behavior?
No.
github-merge-queue bot pushed a commit that referenced this pull request Oct 11, 2023
### Briefly, what does this PR introduce?
And we start to address the mismatches in
#553. This one should be fairly
harmless.

### What kind of change does this PR introduce?
- [x] Bug fix (issue: EcalEndcapN_zmin := 175cm, shift backwards by 1
cm)
- [ ] New feature (issue #__)
- [ ] Documentation update
- [ ] Other: __

### Please check if this PR fulfills the following:
- [ ] Tests for the changes have been added
- [ ] Documentation has been added / updated
- [x] Changes have been communicated to collaborators @johnny8266

### Does this PR introduce breaking changes? What changes might users
need to make to their code?
No.

### Does this PR change default behavior?
No.
@Chao1009
Copy link
Contributor Author

There are bunch of constants exist in the previous template but could not match any component in the new parameter table. Trying to recover some of those in the new template.
image

@github-actions github-actions bot removed the topic: infrastructure Regarding build system, CI, CD label Oct 12, 2023
@Chao1009 Chao1009 marked this pull request as ready for review October 12, 2023 00:22
wdconinc
wdconinc previously approved these changes Oct 12, 2023
Copy link
Contributor

@wdconinc wdconinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me for merging now.

Or we can wait and I can add the inner tracker r variables. I went through those today. Could also wait until a next pr and keep things moving. Your call.

@Chao1009
Copy link
Contributor Author

I think we can wait for the inner tracker updates. There is no urgent need to merge this.

@wdconinc
Copy link
Contributor

There is no urgent need to merge this.

Yeah, but that's how you end up with eternal pull requests that just keep running parallel. My thinking is usually by asking myself the question "is there a clear milestone to call the PR done for which I could right now implement the commits if I only had the time," versus "is this something that could continue to be tweaked for a long time while asymptotically reaching perfection"? If it's the former, ok to wait with merge. If it's the latter, I try to do merges as I go along.

@Chao1009
Copy link
Contributor Author

Chao1009 commented Oct 12, 2023

This has to be

"is this something that could continue to be tweaked for a long time while asymptotically reaching perfection"

But we will update the information (the smaller comparison table) in those issues of "Detector Parameters Update" after merging this PR and fixing some obvious issues (e.g., #559). So the inclusion of the tracker parameters is good for this purpose.

@Chao1009 Chao1009 added this pull request to the merge queue Oct 12, 2023
Merged via the queue into main with commit a8c7369 Oct 12, 2023
85 checks passed
@Chao1009 Chao1009 deleted the update-par-table-template branch October 12, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

Implement the new detector parameters
3 participants