Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a script to compare detector parameter tables #551

Merged
merged 14 commits into from
Oct 12, 2023

Conversation

Chao1009
Copy link
Contributor

@Chao1009 Chao1009 commented Oct 9, 2023

Briefly, what does this PR introduce?

It adds a tool to compare two detector parameter tables

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No

Does this PR change default behavior?

No

@github-actions github-actions bot added the topic: infrastructure Regarding build system, CI, CD label Oct 9, 2023
@Chao1009
Copy link
Contributor Author

Chao1009 commented Oct 9, 2023

Tried with
./bin/compare_detector_parameter_table https://eic.jlab.org/Geometry/Detector/local/D/DetectorParameterTable-20230927.csv https://eic.github.io/epic/artifacts/DetectorParameterTable/epic_craterlake.csv

Looks like tons of work to implement the new parameter table... Will do it in separate PRs (#552).

    "stats": {
        "checked_columns": [
            "Length (cm)",
            "Inner Radius (cm)",
            "Outer Radius (cm)",
            "Offset from Center (cm)",
            "Physical Start (cm)",
            "Physical End (cm)"
        ],
        "table_components": {
            "detector": {
                "total": 67,
                "matched": 16,
                "missing": 51
            },
            "simulation": {
                "total": 32,
                "matched": 16,
                "missing": 16
            }
        },
        "component_values": {
            "checked_components": 16,
            "checked_values": 96,
            "mismatched": 27,
            "missing": 53,
            "correct": 16
        }
    },

@Chao1009
Copy link
Contributor Author

Chao1009 commented Oct 9, 2023

Ready for review. Will need this to check #553

@wdconinc wdconinc added this pull request to the merge queue Oct 12, 2023
Merged via the queue into main with commit 4bcb12c Oct 12, 2023
85 checks passed
@wdconinc wdconinc deleted the compare-det-para-table branch October 12, 2023 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants