-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: proof validation implemented in experimental-api #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergey-melnychuk
requested changes
Jun 12, 2024
sergey-melnychuk
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proof validation exists in
crates::core::storage_proofs
. Due to new requirements, it has been also implemented for the new experimental-api. Branch workflow is as follows:crates::core::storage_proofs
to check the original implementationcrates::core::experimental_api::gen
Things to be checked with more details:
jsonrpc::error
- code value for the errors is it correctly done (possible featureimpl From<FromStrError>
to kick out boilerplatemap_err()?
or different implementation with the current scope)starknet::FieldElemen
t due to pedersen and poseidon hash - insideparse_proof()
conversion fromgen::Felt
tostarknet::FieldElement
so that pedersen and poseidon hash functions could be called (additional usage offelt_to_bits()
andfelt_from_bits()
fromcrates::core::utils
)(Closes #619)