forked from stephenb/sendgrid
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Let mail() and create!() return what their overridden versions do.
This allows us to continue to do MailerClass.mailer_method.deliver
- Loading branch information
1 parent
4e93240
commit 4ff3e21
Showing
1 changed file
with
2 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4ff3e21
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be better to use super.tap or returning() for preserve the return value
4ff3e21
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps. Semantically there is no difference, but it may be safer if someone edits this further.