Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keynote Manager stopped working with Revit 22.1.1.516 Update #1371

Closed
scottofazphx opened this issue Nov 2, 2021 · 8 comments · Fixed by #1398
Closed

Keynote Manager stopped working with Revit 22.1.1.516 Update #1371

scottofazphx opened this issue Nov 2, 2021 · 8 comments · Fixed by #1398
Labels
Tools Issues related to pyRevit commands [subsystem]

Comments

@scottofazphx
Copy link

Our Keynote file is hosted on autodesk docs and has been working perfect up until this last revit update now when we try to open it we get a "NoneType" object has no attribute value error
Screenshot 2021-11-02 145335
.

@cloghmani3182
Copy link

We are receiving the same exact error message for Manage Keynotes on one of my office's project files. Can we please find a fix for this error message? Also, does anyone know of a temporary workaround while this is being resolved with regard to keynoting?

@nterranova-fsb
Copy link

nterranova-fsb commented Nov 11, 2021

We are seeing this error as well. We are in a ACC Revit 2020 (20.2.40.65) project, but noticed this error popped up when we upgraded the Desktop Connector from 14.3 to 15.1. I will update once I downgrade to verify that solves the issue.

Update:
The keynote manager worked with Revit 20.2.40.65 and Desktop Connector 14.13.0.1525
The keynote manager failed with Revit 20.2.40.65 and Desktop Connector 15.1.0.1587
The keynote manager worked with Revit 20.2.60.15 and Desktop Connector 14.13.0.1525
The keynote manager failed with Revit 20.2.60.15 and Desktop Connector 15.1.0.1587

@ckuhnMPLS
Copy link

ckuhnMPLS commented Nov 12, 2021

Same issue and just posted as well. Re-installing to 2021.1.4 has been my fix in the meantime.

@aconchado
Copy link

We're getting the same error with Revit 2021.1.4 and Desktop Connector 15.0.0.1540.

@olalancette
Copy link
Contributor

Here is the error if we remove the try/except:

Traceback (most recent call last): File "C:\pyRevit\main\extensions\pyRevitTools.extension\pyRevit.tab\Drawing Set.panel\Keynotes.pushbutton\script.py", line 1376, in <module> File "C:\pyRevit\main\extensions\pyRevitTools.extension\pyRevit.tab\Drawing Set.panel\Keynotes.pushbutton\script.py", line 337, in __init__ File "C:\pyRevit\main\extensions\pyRevitTools.extension\pyRevit.tab\Drawing Set.panel\Keynotes.pushbutton\script.py", line 585, in _determine_kfile File "C:\pyRevit\main\pyrevitlib\pyrevit\interop\adc.py", line 187, in sync_file File "C:\pyRevit\main\pyrevitlib\pyrevit\interop\adc.py", line 182, in is_synced AttributeError: 'NoneType' object has no attribute 'Value'

The error seems to be in the function "adc._get_item_property_id_value", it is looking for prop_def = 'LocalState' but it seems that they changed the Id to "DesktopConnector.Core.LocalState"

If we change line 179 with :
prop_val = _get_item_property_id_value(adc, drive, item, 'DesktopConnector.Core.LocalState')
It will work, but I would suggest to add a version checker somewhere >15.

@cattaca248
Copy link

I have the same issue. I tried scouting for the lines of code referenced in the fix above and no luck. Really need the keynote manager working again!

@olalancette
Copy link
Contributor

@cattaca248 see pull request : #1398 (in the "Files changed" tab)

@cattaca248
Copy link

@olalancette Thank you so much for the nudge. I found the location where the reference needed to be changed and got the updated code. All fixed!

@eirannejad eirannejad linked a pull request Dec 24, 2021 that will close this issue
eirannejad pushed a commit that referenced this issue Dec 24, 2021
Thank you! Great fix
eirannejad added a commit that referenced this issue Dec 24, 2021
eirannejad added a commit that referenced this issue Dec 24, 2021
eirannejad pushed a commit that referenced this issue Dec 24, 2021
Thank you! Great fix
eirannejad added a commit that referenced this issue Dec 26, 2021
* added notes for revit 2022 export hook

* Forms getvaluewindow slider (#1247)

* fixed host adder and added 2020.2.3

* added 2020.1.1 to hosts

* Added slider panel with number display to GetValueWindow class in pyrevit.forms with new forms function ask_for_number_slider

Co-authored-by: Ehsan Iran-Nejad <eirannejad@gmail.com>

* French translations (#1250)

* fixed host adder and added 2020.2.3

* added 2020.1.1 to hosts

* Kept on going with french translations of pyRevit buttons and tooltips

* Squashed commit of the following:

commit 71df181
Author: Ehsan Iran-Nejad <eirannejad@gmail.com>
Date:   Tue May 18 12:30:10 2021 -0700

    added notes for revit 2022 export hook

Co-authored-by: Ehsan Iran-Nejad <eirannejad@gmail.com>

* code cleanups

* Modelchecker extra function (#1257)

* fixed host adder and added 2020.2.3

* added 2020.1.1 to hosts

* Kept on going with french translations of pyRevit buttons and tooltips

* Update modelchecker_check.py

added analytical model elements check

Co-authored-by: Ehsan Iran-Nejad <eirannejad@gmail.com>

* Bump urllib3 from 1.26.4 to 1.26.5 (#1261)

* fixed host adder and added 2020.2.3

* added 2020.1.1 to hosts

* Bump urllib3 from 1.26.4 to 1.26.5

Bumps [urllib3](https://github.com/urllib3/urllib3) from 1.26.4 to 1.26.5.
- [Release notes](https://github.com/urllib3/urllib3/releases)
- [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst)
- [Commits](urllib3/urllib3@1.26.4...1.26.5)

---
updated-dependencies:
- dependency-name: urllib3
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: Ehsan Iran-Nejad <eirannejad@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump urllib3 from 1.26.4 to 1.26.5 in /docs (#1262)

* fixed host adder and added 2020.2.3

* added 2020.1.1 to hosts

* Bump urllib3 from 1.26.4 to 1.26.5 in /docs

Bumps [urllib3](https://github.com/urllib3/urllib3) from 1.26.4 to 1.26.5.
- [Release notes](https://github.com/urllib3/urllib3/releases)
- [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst)
- [Commits](urllib3/urllib3@1.26.4...1.26.5)

---
updated-dependencies:
- dependency-name: urllib3
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: Ehsan Iran-Nejad <eirannejad@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* List Titleblocks on Sheets - added shift click mode to directly select all titleblocks without print/console window (#1276)

* Hotfix/telemetry username (#1256)

* fixed db version check

* fixed host adder and added 2020.2.3

* added 2020.1.1 to hosts

* use windows identity instead

Co-authored-by: Ehsan Iran-Nejad <eirannejad@gmail.com>

* Added missed code re issue  #1225

* Pattern legend maker adjustments (#1259)

* fixed host adder and added 2020.2.3

* added 2020.1.1 to hosts

* Kept on going with french translations of pyRevit buttons and tooltips

* Update modelchecker_check.py

added analytical model elements check

* create_filledregion foregroundpatternId >2019

* filled region type change

* added example on how to document module to answer https://discourse.pyrevitlabs.io/t/room-and-area-location-point/447/4

Co-authored-by: Ehsan Iran-Nejad <eirannejad@gmail.com>

* Updated tooltip

* added revit 2022.0.1

* Modelchecker improvements - added Reference planes lister (#1277)

* fixed host adder and added 2020.2.3

* added 2020.1.1 to hosts

* upped to 4.8.7 and added new product codes

* fixed cpython version check on about window

* pyrevit settings no longer attempts at reattaching for all users

* bin update 4.8.7

* cleaned up icons

* added revit 2022 to list

* Allow Dialogs in Journal Playback (#1220)

* allow dialogs draft

* it is the other way around

Co-authored-by: Tamás Déri <tamas.deri@in-ex.hu>

* code cleanups after adding allowdialogs option

* I translated in french the sum total button as an example (#1218)

* fixed host adder and added 2020.2.3

* added 2020.1.1 to hosts

* added try/except to wipe collaboration cache tool to handle case when there is no cache folder in a version of revit

* Changed the way checker handles the unloaded links for rvtlinks and rvtlinks phases section

* Revert "added try/except to wipe collaboration cache tool to handle case when there is no cache folder in a version of revit"

This reverts commit f2fca00.

* rearranged the family collection part + added generic model count as rectangle

* Change the sum total button translation to include french

Co-authored-by: Ehsan Iran-Nejad <eirannejad@gmail.com>

* fixed bad build for default engine runner

* allowdialogs fix (#1221)

Co-authored-by: Tamás Déri <tamas.deri@in-ex.hu>

* fixed issue #1224 [tool]

* improvements related to issue #1225 [telemetry]

* Create modelchecker_Warnings_check.py

* Create modelchecker_Warnings_check.py (#1231)

* modified inplace families tool + added min version to preflight

modified the inplace families tool to create a 3D view with isolated items
added min version to preflight checks to be 2019

* added close_others to inplace family tool

* translated the preflight check tooltip

* fixed issue #1237

* did a few french translation for some bundles, titles and tooltips

* Some morning translations

* fixed some yaml mis formatting from my previous commit

* added new revit versions

* Even more translations in French

* pulldown translation in the drawing set section

* Added Revit 2022 Icon (#1234)

* fixed host adder and added 2020.2.3

* added 2020.1.1 to hosts

* Added Revit 2022 Icon

Co-authored-by: Ehsan Iran-Nejad <eirannejad@gmail.com>

* Fix config reading for switches in CommandSwitchWindow (#1242)

typo in conditional statement

* fixed issue #1240 [tool]

* fixed issue #1228 [installer]

* upped version to 4.8.8

* bin update 4.8.8

* released 4.8.8

* Kept on going with french translations of pyRevit buttons and tooltips

* Update modelchecker_check.py

added analytical model elements check

* create_filledregion foregroundpatternId >2019

* filled region type change

* added example on how to document module to answer https://discourse.pyrevitlabs.io/t/room-and-area-location-point/447/4

* reference planes lister

* mod

* refplanes mod, added schedules not on sheet check & small mod to basic model checker

Co-authored-by: Ehsan Iran-Nejad <eirannejad@gmail.com>
Co-authored-by: thumDer <54556708+thumDer@users.noreply.github.com>
Co-authored-by: Tamás Déri <tamas.deri@in-ex.hu>
Co-authored-by: Alex D'Aversa <44062587+alexdaversa@users.noreply.github.com>
Co-authored-by: Davide Giannuzzi <31637386+deddolo@users.noreply.github.com>
# Conflicts:
#	bin/pyrevit-hosts.json
#	dev/pyRevitLabs/pyRevitLabs.Common/UserEnv.cs

* added Revit 2020 and 2021 recent updates

* Update modelchecker_Warnings_check.py (#1302)

* fixed host adder and added 2020.2.3

* added 2020.1.1 to hosts

* Update modelchecker_Warnings_check.py

Removed unnecessary revit modules & and list
in reply to #1297 (comment)

Co-authored-by: Ehsan Iran-Nejad <eirannejad@gmail.com>

* register_dockable_panel() to return panel instance (#1323)

Co-authored-by: Tamás Déri <tamas.deri@in-ex.hu>

* removed typo as per #1329 (comment) (#1330)

* fixed host adder and added 2020.2.3

* added 2020.1.1 to hosts

* Update script.py

removed typo as per #1329 (comment)

Co-authored-by: Ehsan Iran-Nejad <eirannejad@gmail.com>

* Fixes issue #1327

* Preflight Checks: Revision schedule filtering (#1333)

* fixed host adder and added 2020.2.3

* added 2020.1.1 to hosts

* Preflight Checks: Revision schedule filtering

Now it is fixed!
ref: #1293 (comment)

Co-authored-by: Ehsan Iran-Nejad <eirannejad@gmail.com>

* Preflight : model group & model group types count (#1334)

* fixed host adder and added 2020.2.3

* added 2020.1.1 to hosts

* Preflight : model group & model group types count

Preflight checks: fixed model group and model group types count as per #1136

Co-authored-by: Ehsan Iran-Nejad <eirannejad@gmail.com>

* 1299 csv headers (#1332)

* fixed host adder and added 2020.2.3

* added 2020.1.1 to hosts

* Submitting PR to address Issue 1299. To not be disruptive to others' workflows, include headers has been added as a switch for shift-click. I have also included an option to select a folder for schedule export in shift-click as I do not often save csvs in the options given.

Co-authored-by: Ehsan Iran-Nejad <eirannejad@gmail.com>

* Reload Keynotes before Print Sheets (#1331)

* fixed host adder and added 2020.2.3

* added 2020.1.1 to hosts

* Submitting PR to address Issue 1264.

Co-authored-by: Ehsan Iran-Nejad <eirannejad@gmail.com>

* UPDATE method to Convert Rhino Meshes to Revit Solids using RhinoInside.Revit (#1343)

* fixed host adder and added 2020.2.3

* added 2020.1.1 to hosts

* UPDATE method to Convert meshes to solids using RhinoInside.Revit

Co-authored-by: Ehsan Iran-Nejad <eirannejad@gmail.com>

* Update schedules_not_on_sheet_check.py (#1336)

updated the description of the check _ after watching bimxt I noticed I forgot that!

* added pyTiba to extensions

* Added revit 2022.1 to hosts db

* Create main.yml

* python37 and pipenv install

* try installing py3.9 using pyenv

pyrevit cli code is python 3.9

* installing py39 using github actions

* ensure msbuild

* start using dotnet for build

* modern dotnet: directory props

* modern dotnet: sdk-style project, pyrevit-doctor

* Update query.py (#1346)

* fixed host adder and added 2020.2.3

* added 2020.1.1 to hosts

* Update query.py

This is probably a very rare occurrence but when the first legend found happens to be a legend view template, it can cause addins like "Copy Legends" to fail

Co-authored-by: Ehsan Iran-Nejad <eirannejad@gmail.com>

* Some more french translations in the Views dropdown (#1352)

* use latest windows

* updated vscode settings

* now using modern dotnet to build labs

* csproj files now add their dependencies to bin

* removed admin user files

moving to multiple installers and don't need these anymore

* pyrevit runtime projects are now using modern dotnet

* pyrevitloader projects now use modern dotnet

* remove msbuild references from build scripts

* renamed projects for consistency

* more vscode settings

* moved dlls into dev/libs

* pythonnet is also built with modern dotnet

* cli cleanups

* wpf forms now uses modern dotnet sdk

* cleaned up manifest files

* go projects now build with modern go

* prepped for testing ci build

* testing ci build

* updated required tools

* ci build now updates submodules

* more exclusions in vsode

* added --debug to pyrevit dev cli

* pyrevit dev cli can now reset to version file

* dev cli now sets build number

* dev cli can now update product uuids

* dev cli now sets products and updates data file

* fixed bad func call

* dev cli cleanups

* show bin on root in vscode

* dev cli now updates copyright on installer files

* first draft of innosetup installer

* fixed a few installer bugs

* dev cli can now build installers

* fixed dotnet build versioning

* changed build steps

* fixed build issue on loader and runners

* added upload step

* fixed upload error

* updated cli installer and added to ci build

* cli now reports the long version

* ci now builds 4 installers

* ci uploads installers in one package

* ci now really builds all 4 installers

* ci now uses same uuid for user and admin installers

* ugh

* this one has to be right

* ci now signs binaries and installers

* fix for installer signing error

no space in installer files

* up to 4.8.9 for RC branch

* added feature #1341 (#1342)

* fixed host adder and added 2020.2.3

* added 2020.1.1 to hosts

* added feature #1341

* fixed indent

Co-authored-by: Ehsan Iran-Nejad <eirannejad@gmail.com>

* pr/1341 cleanup

* added invoke by_host dll test

* ci/cd only on develop

* Workaround Revit 2022 Removal of UnitType from Parameter Definition (#1363)

* fixed host adder and added 2020.2.3

* added 2020.1.1 to hosts

* Workaround Revit 2022 Removal of UnitType from Parameter Definition

This is a brute force fix to the issue described. This does not
necessarily fix the issue, and code is probably broken elsewhere.

Co-authored-by: Ehsan Iran-Nejad <eirannejad@gmail.com>

* pr cleanup

* Translation in French of UI / Tools (#1370)

* Some more french translations in the Views dropdown

* View section translated in french

* Spy tools in French

* Toggles tools in French

* Update bundle.yaml

* Pick and Set Workset in French

* filter and isolate in French

* almost there everything in French

* Create bundle.yaml

* End of french translation of tools in UI

* only hide dev/**/bin

* added new hosts

* added manual mode to github action

* action update

* updated pyrevit version to use new format

* handle ! prefix for exclusion (#1385)

Co-authored-by: Tamás Déri <tamas.deri@in-ex.hu>

* disabled automatic build

* fixed issue #1371 (#1398)

Thank you! Great fix

* Fix error in Select All Clouds with Same Comment (#1395)

* fixed host adder and added 2020.2.3

* added 2020.1.1 to hosts

* Bump urllib3 from 1.26.4 to 1.26.5 (#1261)

* fixed host adder and added 2020.2.3

* added 2020.1.1 to hosts

* Bump urllib3 from 1.26.4 to 1.26.5

Bumps [urllib3](https://github.com/urllib3/urllib3) from 1.26.4 to 1.26.5.
- [Release notes](https://github.com/urllib3/urllib3/releases)
- [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst)
- [Commits](urllib3/urllib3@1.26.4...1.26.5)

---
updated-dependencies:
- dependency-name: urllib3
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: Ehsan Iran-Nejad <eirannejad@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump urllib3 from 1.26.4 to 1.26.5 in /docs (#1262)

* fixed host adder and added 2020.2.3

* added 2020.1.1 to hosts

* Bump urllib3 from 1.26.4 to 1.26.5 in /docs

Bumps [urllib3](https://github.com/urllib3/urllib3) from 1.26.4 to 1.26.5.
- [Release notes](https://github.com/urllib3/urllib3/releases)
- [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst)
- [Commits](urllib3/urllib3@1.26.4...1.26.5)

---
updated-dependencies:
- dependency-name: urllib3
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: Ehsan Iran-Nejad <eirannejad@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Fix error in Select All Clouds with Same Comment

Co-authored-by: Ehsan Iran-Nejad <eirannejad@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* improved build script

* added commit and tag step

* build script fixes

* added publish release step with notes

* activate develop action

* build script fixes

* build script fixes

* build script fixes

* build script fixes

* build script fixes

* build script fixes

* build script fixes

* build script fixes

* build script fixes

* build script fixes

* build script fixes

* build script fixes

* build script fixes

* build script fixes

* build script fixes

* build script fixes

* build script fixes

* added push step

* added push step

* Publish!

* added push step

* added diff to release notes

* New Extensions (#1407)

* extensions.json formatting

* added EF-Tools extension

* added pyChilizer extension

* added pySSG extension

* updated form default number slider

* added cli tag

* build now pushes tags as well

Co-authored-by: Alex D'Aversa <44062587+alexdaversa@users.noreply.github.com>
Co-authored-by: jmcouffin <jmcouffin@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Andrea Tassera <36023527+Dre-Tas@users.noreply.github.com>
Co-authored-by: thumDer <54556708+thumDer@users.noreply.github.com>
Co-authored-by: Tamás Déri <tamas.deri@in-ex.hu>
Co-authored-by: Hardik Doshi <46202854+hdoshi2@users.noreply.github.com>
Co-authored-by: lexiko80-LPA <63026822+lexiko80-LPA@users.noreply.github.com>
Co-authored-by: Biseuv Olzhas <biseuv@yandex.ru>
Co-authored-by: Abbaad Haider <abbaad@algebraaec.com>
Co-authored-by: Olivier Lalancette <24980892+olalancette@users.noreply.github.com>
Co-authored-by: Davide Giannuzzi <82106471+dvdgnz@users.noreply.github.com>
eirannejad added a commit that referenced this issue Dec 26, 2021
* added notes for revit 2022 export hook

* Forms getvaluewindow slider (#1247)

* fixed host adder and added 2020.2.3

* added 2020.1.1 to hosts

* Added slider panel with number display to GetValueWindow class in pyrevit.forms with new forms function ask_for_number_slider

Co-authored-by: Ehsan Iran-Nejad <eirannejad@gmail.com>

* French translations (#1250)

* fixed host adder and added 2020.2.3

* added 2020.1.1 to hosts

* Kept on going with french translations of pyRevit buttons and tooltips

* Squashed commit of the following:

commit 71df181
Author: Ehsan Iran-Nejad <eirannejad@gmail.com>
Date:   Tue May 18 12:30:10 2021 -0700

    added notes for revit 2022 export hook

Co-authored-by: Ehsan Iran-Nejad <eirannejad@gmail.com>

* code cleanups

* Modelchecker extra function (#1257)

* fixed host adder and added 2020.2.3

* added 2020.1.1 to hosts

* Kept on going with french translations of pyRevit buttons and tooltips

* Update modelchecker_check.py

added analytical model elements check

Co-authored-by: Ehsan Iran-Nejad <eirannejad@gmail.com>

* Bump urllib3 from 1.26.4 to 1.26.5 (#1261)

* fixed host adder and added 2020.2.3

* added 2020.1.1 to hosts

* Bump urllib3 from 1.26.4 to 1.26.5

Bumps [urllib3](https://github.com/urllib3/urllib3) from 1.26.4 to 1.26.5.
- [Release notes](https://github.com/urllib3/urllib3/releases)
- [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst)
- [Commits](urllib3/urllib3@1.26.4...1.26.5)

---
updated-dependencies:
- dependency-name: urllib3
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: Ehsan Iran-Nejad <eirannejad@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump urllib3 from 1.26.4 to 1.26.5 in /docs (#1262)

* fixed host adder and added 2020.2.3

* added 2020.1.1 to hosts

* Bump urllib3 from 1.26.4 to 1.26.5 in /docs

Bumps [urllib3](https://github.com/urllib3/urllib3) from 1.26.4 to 1.26.5.
- [Release notes](https://github.com/urllib3/urllib3/releases)
- [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst)
- [Commits](urllib3/urllib3@1.26.4...1.26.5)

---
updated-dependencies:
- dependency-name: urllib3
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: Ehsan Iran-Nejad <eirannejad@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* List Titleblocks on Sheets - added shift click mode to directly select all titleblocks without print/console window (#1276)

* Hotfix/telemetry username (#1256)

* fixed db version check

* fixed host adder and added 2020.2.3

* added 2020.1.1 to hosts

* use windows identity instead

Co-authored-by: Ehsan Iran-Nejad <eirannejad@gmail.com>

* Added missed code re issue  #1225

* Pattern legend maker adjustments (#1259)

* fixed host adder and added 2020.2.3

* added 2020.1.1 to hosts

* Kept on going with french translations of pyRevit buttons and tooltips

* Update modelchecker_check.py

added analytical model elements check

* create_filledregion foregroundpatternId >2019

* filled region type change

* added example on how to document module to answer https://discourse.pyrevitlabs.io/t/room-and-area-location-point/447/4

Co-authored-by: Ehsan Iran-Nejad <eirannejad@gmail.com>

* Updated tooltip

* added revit 2022.0.1

* Modelchecker improvements - added Reference planes lister (#1277)

* fixed host adder and added 2020.2.3

* added 2020.1.1 to hosts

* upped to 4.8.7 and added new product codes

* fixed cpython version check on about window

* pyrevit settings no longer attempts at reattaching for all users

* bin update 4.8.7

* cleaned up icons

* added revit 2022 to list

* Allow Dialogs in Journal Playback (#1220)

* allow dialogs draft

* it is the other way around

Co-authored-by: Tamás Déri <tamas.deri@in-ex.hu>

* code cleanups after adding allowdialogs option

* I translated in french the sum total button as an example (#1218)

* fixed host adder and added 2020.2.3

* added 2020.1.1 to hosts

* added try/except to wipe collaboration cache tool to handle case when there is no cache folder in a version of revit

* Changed the way checker handles the unloaded links for rvtlinks and rvtlinks phases section

* Revert "added try/except to wipe collaboration cache tool to handle case when there is no cache folder in a version of revit"

This reverts commit f2fca00.

* rearranged the family collection part + added generic model count as rectangle

* Change the sum total button translation to include french

Co-authored-by: Ehsan Iran-Nejad <eirannejad@gmail.com>

* fixed bad build for default engine runner

* allowdialogs fix (#1221)

Co-authored-by: Tamás Déri <tamas.deri@in-ex.hu>

* fixed issue #1224 [tool]

* improvements related to issue #1225 [telemetry]

* Create modelchecker_Warnings_check.py

* Create modelchecker_Warnings_check.py (#1231)

* modified inplace families tool + added min version to preflight

modified the inplace families tool to create a 3D view with isolated items
added min version to preflight checks to be 2019

* added close_others to inplace family tool

* translated the preflight check tooltip

* fixed issue #1237

* did a few french translation for some bundles, titles and tooltips

* Some morning translations

* fixed some yaml mis formatting from my previous commit

* added new revit versions

* Even more translations in French

* pulldown translation in the drawing set section

* Added Revit 2022 Icon (#1234)

* fixed host adder and added 2020.2.3

* added 2020.1.1 to hosts

* Added Revit 2022 Icon

Co-authored-by: Ehsan Iran-Nejad <eirannejad@gmail.com>

* Fix config reading for switches in CommandSwitchWindow (#1242)

typo in conditional statement

* fixed issue #1240 [tool]

* fixed issue #1228 [installer]

* upped version to 4.8.8

* bin update 4.8.8

* released 4.8.8

* Kept on going with french translations of pyRevit buttons and tooltips

* Update modelchecker_check.py

added analytical model elements check

* create_filledregion foregroundpatternId >2019

* filled region type change

* added example on how to document module to answer https://discourse.pyrevitlabs.io/t/room-and-area-location-point/447/4

* reference planes lister

* mod

* refplanes mod, added schedules not on sheet check & small mod to basic model checker

Co-authored-by: Ehsan Iran-Nejad <eirannejad@gmail.com>
Co-authored-by: thumDer <54556708+thumDer@users.noreply.github.com>
Co-authored-by: Tamás Déri <tamas.deri@in-ex.hu>
Co-authored-by: Alex D'Aversa <44062587+alexdaversa@users.noreply.github.com>
Co-authored-by: Davide Giannuzzi <31637386+deddolo@users.noreply.github.com>
# Conflicts:
#	bin/pyrevit-hosts.json
#	dev/pyRevitLabs/pyRevitLabs.Common/UserEnv.cs

* added Revit 2020 and 2021 recent updates

* Update modelchecker_Warnings_check.py (#1302)

* fixed host adder and added 2020.2.3

* added 2020.1.1 to hosts

* Update modelchecker_Warnings_check.py

Removed unnecessary revit modules & and list
in reply to #1297 (comment)

Co-authored-by: Ehsan Iran-Nejad <eirannejad@gmail.com>

* register_dockable_panel() to return panel instance (#1323)

Co-authored-by: Tamás Déri <tamas.deri@in-ex.hu>

* removed typo as per #1329 (comment) (#1330)

* fixed host adder and added 2020.2.3

* added 2020.1.1 to hosts

* Update script.py

removed typo as per #1329 (comment)

Co-authored-by: Ehsan Iran-Nejad <eirannejad@gmail.com>

* Fixes issue #1327

* Preflight Checks: Revision schedule filtering (#1333)

* fixed host adder and added 2020.2.3

* added 2020.1.1 to hosts

* Preflight Checks: Revision schedule filtering

Now it is fixed!
ref: #1293 (comment)

Co-authored-by: Ehsan Iran-Nejad <eirannejad@gmail.com>

* Preflight : model group & model group types count (#1334)

* fixed host adder and added 2020.2.3

* added 2020.1.1 to hosts

* Preflight : model group & model group types count

Preflight checks: fixed model group and model group types count as per #1136

Co-authored-by: Ehsan Iran-Nejad <eirannejad@gmail.com>

* 1299 csv headers (#1332)

* fixed host adder and added 2020.2.3

* added 2020.1.1 to hosts

* Submitting PR to address Issue 1299. To not be disruptive to others' workflows, include headers has been added as a switch for shift-click. I have also included an option to select a folder for schedule export in shift-click as I do not often save csvs in the options given.

Co-authored-by: Ehsan Iran-Nejad <eirannejad@gmail.com>

* Reload Keynotes before Print Sheets (#1331)

* fixed host adder and added 2020.2.3

* added 2020.1.1 to hosts

* Submitting PR to address Issue 1264.

Co-authored-by: Ehsan Iran-Nejad <eirannejad@gmail.com>

* UPDATE method to Convert Rhino Meshes to Revit Solids using RhinoInside.Revit (#1343)

* fixed host adder and added 2020.2.3

* added 2020.1.1 to hosts

* UPDATE method to Convert meshes to solids using RhinoInside.Revit

Co-authored-by: Ehsan Iran-Nejad <eirannejad@gmail.com>

* Update schedules_not_on_sheet_check.py (#1336)

updated the description of the check _ after watching bimxt I noticed I forgot that!

* added pyTiba to extensions

* Added revit 2022.1 to hosts db

* Create main.yml

* python37 and pipenv install

* try installing py3.9 using pyenv

pyrevit cli code is python 3.9

* installing py39 using github actions

* ensure msbuild

* start using dotnet for build

* modern dotnet: directory props

* modern dotnet: sdk-style project, pyrevit-doctor

* Update query.py (#1346)

* fixed host adder and added 2020.2.3

* added 2020.1.1 to hosts

* Update query.py

This is probably a very rare occurrence but when the first legend found happens to be a legend view template, it can cause addins like "Copy Legends" to fail

Co-authored-by: Ehsan Iran-Nejad <eirannejad@gmail.com>

* Some more french translations in the Views dropdown (#1352)

* use latest windows

* updated vscode settings

* now using modern dotnet to build labs

* csproj files now add their dependencies to bin

* removed admin user files

moving to multiple installers and don't need these anymore

* pyrevit runtime projects are now using modern dotnet

* pyrevitloader projects now use modern dotnet

* remove msbuild references from build scripts

* renamed projects for consistency

* more vscode settings

* moved dlls into dev/libs

* pythonnet is also built with modern dotnet

* cli cleanups

* wpf forms now uses modern dotnet sdk

* cleaned up manifest files

* go projects now build with modern go

* prepped for testing ci build

* testing ci build

* updated required tools

* ci build now updates submodules

* more exclusions in vsode

* added --debug to pyrevit dev cli

* pyrevit dev cli can now reset to version file

* dev cli now sets build number

* dev cli can now update product uuids

* dev cli now sets products and updates data file

* fixed bad func call

* dev cli cleanups

* show bin on root in vscode

* dev cli now updates copyright on installer files

* first draft of innosetup installer

* fixed a few installer bugs

* dev cli can now build installers

* fixed dotnet build versioning

* changed build steps

* fixed build issue on loader and runners

* added upload step

* fixed upload error

* updated cli installer and added to ci build

* cli now reports the long version

* ci now builds 4 installers

* ci uploads installers in one package

* ci now really builds all 4 installers

* ci now uses same uuid for user and admin installers

* ugh

* this one has to be right

* ci now signs binaries and installers

* fix for installer signing error

no space in installer files

* up to 4.8.9 for RC branch

* added feature #1341 (#1342)

* fixed host adder and added 2020.2.3

* added 2020.1.1 to hosts

* added feature #1341

* fixed indent

Co-authored-by: Ehsan Iran-Nejad <eirannejad@gmail.com>

* pr/1341 cleanup

* added invoke by_host dll test

* ci/cd only on develop

* Workaround Revit 2022 Removal of UnitType from Parameter Definition (#1363)

* fixed host adder and added 2020.2.3

* added 2020.1.1 to hosts

* Workaround Revit 2022 Removal of UnitType from Parameter Definition

This is a brute force fix to the issue described. This does not
necessarily fix the issue, and code is probably broken elsewhere.

Co-authored-by: Ehsan Iran-Nejad <eirannejad@gmail.com>

* pr cleanup

* Translation in French of UI / Tools (#1370)

* Some more french translations in the Views dropdown

* View section translated in french

* Spy tools in French

* Toggles tools in French

* Update bundle.yaml

* Pick and Set Workset in French

* filter and isolate in French

* almost there everything in French

* Create bundle.yaml

* End of french translation of tools in UI

* only hide dev/**/bin

* added new hosts

* added manual mode to github action

* action update

* updated pyrevit version to use new format

* handle ! prefix for exclusion (#1385)

Co-authored-by: Tamás Déri <tamas.deri@in-ex.hu>

* disabled automatic build

* fixed issue #1371 (#1398)

Thank you! Great fix

* Fix error in Select All Clouds with Same Comment (#1395)

* fixed host adder and added 2020.2.3

* added 2020.1.1 to hosts

* Bump urllib3 from 1.26.4 to 1.26.5 (#1261)

* fixed host adder and added 2020.2.3

* added 2020.1.1 to hosts

* Bump urllib3 from 1.26.4 to 1.26.5

Bumps [urllib3](https://github.com/urllib3/urllib3) from 1.26.4 to 1.26.5.
- [Release notes](https://github.com/urllib3/urllib3/releases)
- [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst)
- [Commits](urllib3/urllib3@1.26.4...1.26.5)

---
updated-dependencies:
- dependency-name: urllib3
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: Ehsan Iran-Nejad <eirannejad@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump urllib3 from 1.26.4 to 1.26.5 in /docs (#1262)

* fixed host adder and added 2020.2.3

* added 2020.1.1 to hosts

* Bump urllib3 from 1.26.4 to 1.26.5 in /docs

Bumps [urllib3](https://github.com/urllib3/urllib3) from 1.26.4 to 1.26.5.
- [Release notes](https://github.com/urllib3/urllib3/releases)
- [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst)
- [Commits](urllib3/urllib3@1.26.4...1.26.5)

---
updated-dependencies:
- dependency-name: urllib3
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: Ehsan Iran-Nejad <eirannejad@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Fix error in Select All Clouds with Same Comment

Co-authored-by: Ehsan Iran-Nejad <eirannejad@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* improved build script

* added commit and tag step

* build script fixes

* added publish release step with notes

* activate develop action

* build script fixes

* build script fixes

* build script fixes

* build script fixes

* build script fixes

* build script fixes

* build script fixes

* build script fixes

* build script fixes

* build script fixes

* build script fixes

* build script fixes

* build script fixes

* build script fixes

* build script fixes

* build script fixes

* build script fixes

* added push step

* added push step

* Publish!

* added push step

* added diff to release notes

* New Extensions (#1407)

* extensions.json formatting

* added EF-Tools extension

* added pyChilizer extension

* added pySSG extension

* updated form default number slider

* added cli tag

* build now pushes tags as well

* updated build triggers

Co-authored-by: Alex D'Aversa <44062587+alexdaversa@users.noreply.github.com>
Co-authored-by: jmcouffin <jmcouffin@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Andrea Tassera <36023527+Dre-Tas@users.noreply.github.com>
Co-authored-by: thumDer <54556708+thumDer@users.noreply.github.com>
Co-authored-by: Tamás Déri <tamas.deri@in-ex.hu>
Co-authored-by: Hardik Doshi <46202854+hdoshi2@users.noreply.github.com>
Co-authored-by: lexiko80-LPA <63026822+lexiko80-LPA@users.noreply.github.com>
Co-authored-by: Biseuv Olzhas <biseuv@yandex.ru>
Co-authored-by: Abbaad Haider <abbaad@algebraaec.com>
Co-authored-by: Olivier Lalancette <24980892+olalancette@users.noreply.github.com>
Co-authored-by: Davide Giannuzzi <82106471+dvdgnz@users.noreply.github.com>
@eirannejad eirannejad added the Tools Issues related to pyRevit commands [subsystem] label Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tools Issues related to pyRevit commands [subsystem]
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants