Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve cleaning the project #413

Closed
wmdietl opened this issue Feb 22, 2023 · 4 comments · Fixed by #502 or #896
Closed

Improve cleaning the project #413

wmdietl opened this issue Feb 22, 2023 · 4 comments · Fixed by #502 or #896
Assignees
@Ao-senXiong

Comments

@wmdietl
Copy link
Member

wmdietl commented Feb 22, 2023

Build the project with ./gradlew assemble.
Then, after running ./gradlew clean, there are still many build artifacts lying around, e.g. nearly 2000 .class files and javadoc HTML files.
If there is a different task to run to clean all files, document it. (I tried cleanTest and cleanBuild and they don't clean these files.)
If no such task exists, improve the clean task.

Note that there are a few test tasks that use Makefiles. Improve those by including a clean target and make sure these are actually run.
@Ao-senXiong Ao-senXiong self-assigned this May 26, 2023
@Ao-senXiong Ao-senXiong mentioned this issue May 26, 2023
Merged
@wmdietl wmdietl mentioned this issue Aug 30, 2024
Open
Ao-senXiong added a commit to Ao-senXiong/checker-framework that referenced this issue Aug 30, 2024
@Ao-senXiong
Add eisop#413
5a5bbe0
@wmdietl wmdietl reopened this Aug 30, 2024
@wmdietl
Copy link
Member Author

wmdietl commented Aug 30, 2024

@Ao-senXiong Running ./gradlew clean now fails with errors... can you please fix this?
We never run the clean target in CI... so maybe we should add a test that that target actually works.
In #502 (comment) you said you tested that change, which clearly isn't the case...

@Ao-senXiong
Copy link
Member

@Ao-senXiong Running ./gradlew clean now fails with errors... can you please fix this? We never run the clean target in CI... so maybe we should add a test that that target actually works. In #502 (comment) you said you tested that change, which clearly isn't the case...

@wmdietl What command do you use for running the test?

I just tried again with ./gradlew test and ./gradlew clean resulting failure. It seems either nullnessextratest did not run or ./gradlew test clean the generated files itself.

@Ao-senXiong
Copy link
Member

While #502 (comment) these combinations works fine.

@wmdietl
Copy link
Member Author

wmdietl commented Aug 30, 2024

@Ao-senXiong Running ./gradlew clean now fails with errors... can you please fix this? We never run the clean target in CI... so maybe we should add a test that that target actually works. In #502 (comment) you said you tested that change, which clearly isn't the case...

@wmdietl What command do you use for running the test?

I just tried again with ./gradlew test and ./gradlew clean resulting failure. It seems either nullnessextratest did not run or ./gradlew test clean the generated files itself.

I'm not sure what you're trying to say... Can you just try running it twice: ./gradlew clean; ./gradlew clean and the second invocation will cause errors. This might happen, e.g. after just building the project, without running tests, or running only some of the tests. Cleaning the project should always work, regardless of whether tests were run or not.
For rm invocations in Makefiles, try adding - in front of the line (after the tab) to ignore errors.

@Ao-senXiong Ao-senXiong mentioned this issue Aug 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ao-senXiong Ao-senXiong

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@wmdietl @Ao-senXiong