Explain the need having three validateTargetLocationsXX methods
#582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmdietl
requested changes
Oct 21, 2023
framework/src/main/java/org/checkerframework/common/basetype/BaseTypeVisitor.java
Outdated
Show resolved
Hide resolved
| * BaseTypeVisitor#validateTargetLocation(Tree, AnnotatedTypeMirror, TypeUseLocation)} is that | ||
| * this one is only used in {@link BaseTypeVisitor#visitVariable(VariableTree, Void)}. The three | ||
| * different validate methods in the visitor and validator file achieve the same goal and the | ||
| * need for having three is due to implementation reasons. We perform checks for types in |
There was a problem hiding this comment.
You are documenting the implementation here. So don't say due to implementation reasons, but instead what those reasons are.
There was a problem hiding this comment.
I clarify the need of having three different validating methods on each method and refer to each other. I think that's better now, please have a look.
framework/src/main/java/org/checkerframework/common/basetype/BaseTypeVisitor.java
Outdated
Show resolved
Hide resolved
framework/src/main/java/org/checkerframework/common/basetype/BaseTypeVisitor.java
Outdated
Show resolved
Hide resolved
framework/src/main/java/org/checkerframework/common/basetype/BaseTypeVisitor.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Werner Dietl <wdietl@gmail.com>
|
misc_jdk8 failed but misc_jdk11 and misc_jdk17 passed. I re-check the method signature written in the javadoc and am still not sure the cause of the failure |
|
Follow-up work in #798. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the conceptual differences between
BaseTypeVisitor#validateVariablesTargetLocationandBaseTypeVisitor#validateTargetLocation.