Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use AnnotationMirrorSet and remove usages of Set<AnnotationMirror> #790

Merged
merged 4 commits into from
Jun 24, 2024

Conversation

Ao-senXiong
Copy link
Member

No description provided.

Copy link
Member

@wmdietl wmdietl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup! Just add a changelog please.

@@ -3018,8 +3018,8 @@ public ParameterizedExecutableType constructorFromUse(NewClassTree tree) {
*
* @return the annotations that should be applied to enum constructors
*/
protected Set<AnnotationMirror> getEnumConstructorQualifiers() {
return Collections.emptySet();
protected AnnotationMirrorSet getEnumConstructorQualifiers() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add this incompatible change to the changelog?

@wmdietl wmdietl assigned Ao-senXiong and unassigned wmdietl Jun 23, 2024
@Ao-senXiong Ao-senXiong requested a review from wmdietl June 23, 2024 20:41
@Ao-senXiong Ao-senXiong assigned wmdietl and unassigned Ao-senXiong Jun 23, 2024
Copy link
Member

@wmdietl wmdietl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

docs/CHANGELOG.md Outdated Show resolved Hide resolved
@wmdietl wmdietl enabled auto-merge (squash) June 24, 2024 03:03
@wmdietl wmdietl changed the title Use AnnotationMirrorSet and remove usage of Set<AnnotationMirror> Use AnnotationMirrorSet and remove usages of Set<AnnotationMirror> Jun 24, 2024
@wmdietl wmdietl merged commit 00daef8 into eisop:master Jun 24, 2024
39 checks passed
Ao-senXiong added a commit to Ao-senXiong/checker-framework that referenced this pull request Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants