Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT: Remove unused astropy config code #944

Merged
merged 1 commit into from
Apr 10, 2021
Merged

MNT: Remove unused astropy config code #944

merged 1 commit into from
Apr 10, 2021

Conversation

pllim
Copy link
Collaborator

@pllim pllim commented Apr 9, 2021

This is probably leftover from package template. Ginga does not use the astropy configuration system at all.

Also see astropy/astropy#11497

@pllim pllim requested a review from ejeschke April 9, 2021 21:07
@pllim pllim added this to the 3.2 milestone Apr 9, 2021
@pllim pllim added the maintenance Work done to keep code maintained label Apr 9, 2021
ejeschke
ejeschke approved these changes Apr 10, 2021
View reviewed changes
Copy link
Owner

@ejeschke ejeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pllim, Thank you!

I was wondering about this code and whether it was still necessary!

FFTM

@pllim pllim merged commit 8604ff9 into ejeschke:master Apr 10, 2021
@pllim pllim deleted the config-no-write branch April 10, 2021 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ejeschke ejeschke ejeschke approved these changes

Assignees
No one assigned
Labels
maintenance Work done to keep code maintained
Projects
None yet
Milestone
3.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pllim @ejeschke