-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Goals don't update on cursor movement when using VsCodeVim #163
Comments
Indeed, it seems that the problem is that VsCodeVim doesn't call @jesyspa maybe we could ask the VsCodeVim developers what's the correct way to track cursor movement when their extension is enabled? I bet they use their own selection implementation which indeed makes sense for something like a VIM emulator. This way, we could detect that and hook to the correct method. |
I don't have any experience with writing VS Code plugins so I may be misunderstanding: should it be on each plugin to notify when the text editor selection changes, or is this a VSCode issue? I tested it with vscode-neovim and the behaviour is the same... It seems like for normal movement, VsCodeVim uses the |
A little bit of testing later: the events are being generated, but they have type I think the simplest solution may be to add a corresponding option for Here's the code of the extension I cooked up to test this: https://github.com/jesyspa/jytest-vscode |
Oh, that's a great finding @jesyspa , I think indeed with that info we can fix your problem. Indeed I wonder if there is a problem in identifying |
Fixes #163 This makes VsCodeVim cursor tracking work; thanks to Cactus (Anton) Golov for detailed bug reporting and testing.
CHANGES: ---------------------- - Much improved handling of Coq fatal errors, the server is now hardened against them (@ejgallego, ejgallego/coq-lsp#155, ejgallego/coq-lsp#157, ejgallego/coq-lsp#160, fixes ejgallego/coq-lsp#91) - `coq-lsp` now follows the LSP specification regarding initialization strictly (@ejgallego, ejgallego/coq-lsp#168) - New setting for goals to be updated when the selection changes due to a command; this makes VsCodeVim cursor tracking work; thanks to Cactus (Anton) Golov for detailed bug reporting and testing (@ejgallego, @jesyspa, ejgallego/coq-lsp#170, fixes ejgallego/coq-lsp#163) - `coq-lsp` will now warn the user when two files have been opened simultaneously and the parser may go into a broken state :/ (@ejgallego, ejgallego/coq-lsp#169) - Implement request postponement and cancellation. Thus `documentSymbols` will now be postponed until the document is ready, (@ejgallego, ejgallego/coq-lsp#141, ejgallego/coq-lsp#146, fixes ejgallego/coq-lsp#124) - Protocol and VS Code interfaces now support shelved and given_up goals (@ejgallego, ejgallego/coq-lsp#175) - Allow to postpone requests to wait for data to become available on document points; this is implemented to provide a nicer "show goals while I type" experience. Client default has been changed to "show goals on mouse, click, typing, and cursor movement) (@ejgallego, ejgallego/coq-lsp#177, ejgallego/coq-lsp#179) - Store stats per document (@ejgallego, ejgallego/coq-lsp#180, fixes ejgallego/coq-lsp#173)
As discussed on Zulip, in version 0.1.2 of coq-lsp, when
show_goals_on
is set to "Show on click and cursor movement" and the VsCodeVim extension is enabled, moving the cursor using hjkl or the arrow keys doesn't update the goal status (and in fact there's no activity in Coq LSP Server Events).The text was updated successfully, but these errors were encountered: